textql 2.0.0 (new formula) #44799
textql 2.0.0 (new formula) #44799
Conversation
| ENV["GOPATH"] = buildpath | ||
| Language::Go.stage_deps resources, buildpath/"src" | ||
|
|
||
| system "go", "build", "-i", "-ldflags", "-X main.VERSION 2.0.0", "#{buildpath}/src/github.com/dinedal/textql/cmd/textql.go" |
There was a problem hiding this comment.
Why is -i necessary here?
|
Thank you for the feedback, all of your suggestions / corrections have been applied. Please let me know if there is anything else, and I'm happy to adjust it. |
|
The test failed: |
|
Ping? |
|
Really sorry, I released a new version to fix the issue, but didn't get to make the changes here. Should I re-open with a new, updated branch? |
|
No, you can update this PR by either pushing a new commit or squashing in the existing one and force-pushing. |
dinedal
force-pushed
the
textql-2.0.0
branch
from
ce02a2f
to
1a116cb
Compare
|
Force pushed a new commit. |
dinedal
force-pushed
the
textql-2.0.0
branch
5 times, most recently
from
d8dc6d6
to
a08f674
Compare
|
|
||
| system "go", "build", "-ldflags", "-X main.VERSION=2.0.2", "#{buildpath}/src/github.com/dinedal/textql/textql/main.go" | ||
| mv "main", "textql" | ||
| bin.install "textql" |
There was a problem hiding this comment.
You can merge the three lines above by adding "-o", "#{bin}/textql" to the go build line.
dinedal
force-pushed
the
textql-2.0.0
branch
5 times, most recently
from
7842a2e
to
114f4de
Compare
Textql allows fast execution of SQL statements over text files. Supports a *nix-like interface, stdin/stdout and pipes. Avoids disk access unless requested.
dinedal
force-pushed
the
textql-2.0.0
branch
from
114f4de
to
3581224
Compare
|
Changes made as requested, happy to do any more you feel are needed. |
|
Thank you for your contribution to Homebrew @dinedal; we appreciate it! 🎉 |
Textql allows fast execution of SQL statements over text files. Supports a *nix-like interface, stdin/stdout and pipes. Avoids disk access unless requested.