-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Conversation
end | ||
|
||
test do | ||
output = shell_output("#{bin}/swiftgen-assets #{pkgshare}/Images.xcassets").strip | ||
assert_equal output, (pkgshare/"assets.swift").read.strip, "swiftgen-assets failed" | ||
shell_output("#{bin}/swiftgen --version") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use system "#{bin}/swiftgen", "--version"
if you don’t use the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed I don't use the output, but I want all the other checks that Homebrew makes with shell_output
, especially ohai
the command + ensuring the exitstatus
is 0
(as per previous recommandation of Homebrew team here), all of which system
doesn't do, right?
Or maybe there is another Homebrew wrapper function that does all the checks but to use when you don't need the output, idk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system
works exactly like shell_output
except that it doesn’t capture the output; so that’s exactly what you’re looking for here 😉
It’s a wrapper, not the bare-bone Ruby system
: https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/formula.rb#L1309
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! Didn't know it was a wrapper too, thx for the info 😉
Just fixed it!
Thank you for your contribution @AliSoftware; we appreciate it! 🎉 |
This installation seems to fail for some users because BrewBot brewed a bottle on your own servers — on which Xcode is installed in See SwiftGen/SwiftGen#35 (comment) Any suggestion on how to solve this? Maybe add a post-script step where I add an |
@AliSoftware We probably need to add a Thanks! |
@AliSoftware I see you already did! Thanks: #45008 |
Yep indeed, thx! |
Simple version bump with new features
Notes:
rake install
command as changed and now takes the directories where to install$bin
and$lib
(Frameworks)pkgshare
(hence the big diff in the formula there)