This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
dfmt 0.4.1 #45242
Closed
dfmt 0.4.1 #45242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 |
|
The tester appears to have had a hiccough... |
|
@BrewTestBot test this please |
|
|
||
| system "#{bin}/dfmt", "-i", "test.d" | ||
|
|
||
| diff "test.d", "test_expected.d" |
There was a problem hiding this comment.
What's the purpose of this line, out of interest? Just wondering since we're not checking for anything here, and diff as a command isn't likely to ever fail?
There was a problem hiding this comment.
I had assumed that the result of diff would be checked. Fixed now.
John-Colvin
force-pushed
the
patch-30
branch
2 times, most recently
from
57d0b44
to
1836d92
Compare
|
|
||
| system "#{bin}/dfmt", "-i", "test.d" | ||
|
|
||
| system "diff", "test.d", "test_expected.d" |
There was a problem hiding this comment.
Instead of writing an expected result then diff-ing it you can put it in a variable (e.g. test_expected) then use assert_equal test_expected, (testpath/"test.d).read.
|
Thank you for your contribution to Homebrew @John-Colvin; we appreciate it! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dfmt is a tool for formatting D source code. It's well maintained and in the long term is likely to become part of the main DMD distribution (At some point I will split all the constituent parts of
dmd.rbout into separate packages, so don't worry, this formula won't become obsolete).No, there isn't a
make install.