ansible-cmdb 1.6 (new formula)

[hryamzik]

No description provided.

[dunn]

Looks like the makefile is trying to write directly to /usr/local/lib instead of to the Cellar: http://bot.brew.sh/job/Homebrew%20Pull%20Requests/35392/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/install_ansible_cmdb/

[dunn]

The solution is probably just to pass a prefix argument to make.

[hryamzik]

@dunn so does it have to be patched?

[dunn]

If the Makefile doesn't allow the install prefix to be customized, then yeah.

[DomT4]

Suspect this is redundant. We can handle reading simple URLs for version numbers.

[hryamzik]

@DomT4 you mean version could be omitted or used as a variable?

[hryamzik]

 * Non-libraries were installed to "/usr/local/Cellar/ansible-cmdb/1.6/lib"
Installing non-libraries to "lib" is discouraged.
The offending files are:

Ok, I'll inreplace this. Is there anything else that has to be fixed?

[MikeMcQuaid]

@hryamzik brew audit lists a few other issues: https://travis-ci.org/Homebrew/homebrew/jobs/87652927#L382

[hryamzik]

@MikeMcQuaid got it, thanks, now cleaning up locally.

ansible-cmdb:
 * Don't need to interpolate "prefix" with inreplace
 * Don't need to interpolate "bin" with inreplace

Any suggestions on this? I don't see any other way to replace full paths.

[MikeMcQuaid]

@hryamzik That's telling you that "#{prefix}" is the same as prefix

[hryamzik]

@MikeMcQuaid indeed, thanks!

[DomT4]

Can just do bin.mkpath here.

[hryamzik]

@DomT4 thanks, done.

[apjanke]

Not supporting PREFIX in a Makefile sounds worthy of an upstream bug report; that's pretty basic.

Looks like the audit problems are all fixed now. Could you squash this to a single commit to avoid cluttering up Homebrew's git history?

Also, where did the "6.3" in the issue title come from? Looks like this program is v 1.6. (1.8 is available now, too.)

[MikeMcQuaid]

Not supporting PREFIX in a Makefile sounds worthy of an upstream bug report; that's pretty basic.

👍

[hryamzik]

@apjanke, all fixed, I'll take a look at 1.8 a bit later and will make a new PR.

[apjanke]

Good to go. Merged. Thanks for your contribution to Homebrew!