Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Boost 1.59.0 #45564

Closed
wants to merge 15 commits into from
Closed

Boost 1.59.0 #45564

wants to merge 15 commits into from

Conversation

MikeMcQuaid
Copy link
Member

Another try from #43994.

@DomT4
Copy link
Member

DomT4 commented Nov 1, 2015

I nearly went and closed this with a slightly grumpy message about checking prior PRs before submitting new ones 😅.

@MikeMcQuaid
Copy link
Member Author

@DomT4 BRING IT 😆

@DomT4
Copy link
Member

DomT4 commented Nov 1, 2015

😜

@MikeMcQuaid
Copy link
Member Author

CI is 🍏. Will try to build brew uses boost locally to verify what else needs done.

@DomT4 DomT4 mentioned this pull request Nov 1, 2015
Closed
@MikeMcQuaid
Copy link
Member Author

Think I've fixed all the issues here.

@MikeMcQuaid
Copy link
Member Author

@BrewTestBot test this please

DomT4
DomT4 reviewed Nov 2, 2015
View reviewed changes
Library/Formula/boost-python.rb
@@ -42,6 +33,14 @@ class BoostPython < Formula
def install
ENV.universal_binary if build.universal?

if stable?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be build.stable? or?

@DomT4
Copy link
Member

DomT4 commented Nov 2, 2015

Did these get checked locally or do they need bumping after this is merged?

homebrew/fuse/encfs
homebrew/fuse/ori
homebrew/head-only/kakoune
homebrew/versions/ledger26
homebrew/versions/libmongoclient-legacy
homebrew/versions/mapnik2
homebrew/versions/mongodb26
homebrew/versions/thrift090
homebrew/x11/inkscape
homebrew/x11/scantailor

@MikeMcQuaid
Copy link
Member Author

@DomT4 Checked all those in versions.

@DomT4
Copy link
Member

DomT4 commented Nov 2, 2015

Nice. Thanks Mike.

@MikeMcQuaid
Copy link
Member Author

Others look good too 👍

@MikeMcQuaid
Copy link
Member Author

@BrewTestBot test this please

@MikeMcQuaid MikeMcQuaid deleted the boost-159 branch November 3, 2015 04:38
@dplarson dplarson mentioned this pull request Nov 3, 2015
Closed
@tdsmith
Copy link
Contributor

tdsmith commented Nov 3, 2015

Thanks Mike!

@MikeMcQuaid
Copy link
Member Author

@tdsmith My (almost) pleasure!

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MikeMcQuaid @DomT4 @tdsmith @dplarson @denji