Add dcadec formula #46411
Add dcadec formula #46411
Conversation
|
|
||
| def install | ||
| system "make", "all" | ||
| unless File.exist?("test/samples/README") |
There was a problem hiding this comment.
When would this file exist/not exist?
There was a problem hiding this comment.
It's in the submodule, and doesn't exist when downloading the tarball.
There was a problem hiding this comment.
In that case it'll never exist. If you use https://github.com/foo86/dcadec.git as the URL and provide :revision and :tag it'll download the submodules for you.
There was a problem hiding this comment.
Does that lock --HEAD to always installing that revision, or just indicate which one the tar.gz comes from?
There was a problem hiding this comment.
Nope, --HEAD is still unlocked but will share the repository. Homebrew will just check it out to the right revision.
There was a problem hiding this comment.
So does that replace the .tar.gz URL, then?
|
@BrewTestBot test this please. |
No description provided.