Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

yank 0.5.0 #46515

Closed
wants to merge 1 commit into from
Closed

yank 0.5.0 #46515

wants to merge 1 commit into from

Conversation

dongcarl
Copy link
Contributor

Caveat: running brew audit yank --strict --online gives this

==> brew style yank

1 file inspected, no offenses detected

==> audit problems
yank:
 * Description shouldn't include the formula name

Error: 1 problem in 1 formula

I'm guessing that the audit rule "Description shouldn't include the formula name" was added to prevent people from writing things like " does blah blah blah." However I think this formula warrants an exception doesn't it?

@DomT4
Copy link
Member

DomT4 commented Nov 30, 2015

I'm guessing that the audit rule "Description shouldn't include the formula name" was added to prevent people from writing things like " does blah blah blah."

Nope. The audit rule was added because we already include the name by default on desc calls:

brew desc valgrind
valgrind: Dynamic analysis tools (memory, debug, profiling)

And brew info includes the formula name:

valgrind: stable 3.11.0 (bottled), HEAD
Dynamic analysis tools (memory, debug, profiling)
http://www.valgrind.org/
Not installed
From: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/valgrind.rb

@dongcarl
Copy link
Contributor Author

dongcarl commented Dec 1, 2015

@DomT4 I see! However I'm using the word "Yank" as a verb in the description so hopefully it'll be approved 😄

@DomT4
Copy link
Member

DomT4 commented Dec 1, 2015

Heh, I'll let it go in this circumstance given that.

Merged in fdfe971. Thank you for another Homebrew contribution @dongcarl! 😺

@DomT4 DomT4 closed this in fdfe971 Dec 1, 2015
@dongcarl dongcarl deleted the yank-update branch December 1, 2015 06:42
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants