Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

postgrest 0.3.0.1 #46773

Closed
wants to merge 1 commit into from
Closed

postgrest 0.3.0.1 #46773

wants to merge 1 commit into from

Conversation

xDAGRONx
Copy link
Contributor

@xDAGRONx xDAGRONx commented Dec 7, 2015

No description provided.

@begriffs begriffs mentioned this pull request Dec 7, 2015
Merged
@begriffs
Copy link
Contributor

begriffs commented Dec 7, 2015

When I build the release binary I run the strip program on it which makes the binary smaller. Do you think you could add that step to the brew build process?

@xDAGRONx
Copy link
Contributor Author

xDAGRONx commented Dec 7, 2015

I can probably manage that. Does it need to run with any particular set of arguments?

@xDAGRONx
Copy link
Contributor Author

xDAGRONx commented Dec 7, 2015

The package uses cabal install. Would the --enable-executable-stripping or --enable-library-stripping options accomplish the same thing?

@begriffs
Copy link
Contributor

begriffs commented Dec 7, 2015

You're right, it appears that --enable-executable-stripping will call strip for you.

@xDAGRONx
Copy link
Contributor Author

xDAGRONx commented Dec 7, 2015

Awesome. I'll add that to the formula.

@xDAGRONx
postgrest 0.3.0.1
40a197e 
Make postgrest test compatible with ruby 1.8

Remove call to Process.spawn, and replace with fork, exec, and
Process.detach.
@begriffs
Copy link
Contributor

Yay it passes the tests now! Once you add --enable-executable-stripping and it keeps passing the tests do you know how we get somebody to merge it?

@xDAGRONx
Copy link
Contributor Author

When I created the formula, someone merged it within a day of the tests passing. I was planning on adding the flag as a separate commit after it got merged, but I didn't expect it to take this long.

@DomT4
Copy link
Member

DomT4 commented Dec 10, 2015

Apologies. I've actually looked over this quite a few times over the last couple days and presumed I should wait on you to add the requested flag. Didn't realise you were waiting on us to merge. Will do that now 😉

@DomT4
Copy link
Member

DomT4 commented Dec 10, 2015

Merged in 926b8be. Thank you for another contribution to Homebrew @xDAGRONx; we appreciate it! 😺

@DomT4 DomT4 closed this in 926b8be Dec 10, 2015
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xDAGRONx @begriffs @DomT4