This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gyp
to my knowledge doesn't tag releases, and consequently we've turned it down from the core a couple times before. I'm pretty sure this is still the case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, there are still no tags. I just found some previously closed / rejected pull requests that have tried to do the same, so I guess this one might also not be merged. That's ok and my fault, as I have not searched for them before submitting the pull request.
Do you see any chance to get a formula for
gyp
? Maybe a fork of the official project that just adds tags and tarballs or similar? I am open for all ideas. Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need an official upstream tag for this to be admissible. I would be surprised if upstream ever go there, to be honest.
Nothing in the world stopping you adding this to a created tap of your own though, if you wanted to support it there. Some documentation on doing that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!