ksh: functioning download urls

[ilovezfs]

Use alternate urls until the canonical url at AT&T comes back.

Apparently, the main url has been down since at 19th Jan 2016: https://aur.archlinux.org/cgit/aur.git/commit/PKGBUILD?h=ksh&id=34f5b91260f859104bedd67cdbcd7e7f8cf18b88

Reported to admin at kornshell.com

[ilovezfs]

Do you prefer mirrorservice for the primary since it's https, or the apple url?

[DomT4]

Probably the former, especially if we can temporarily ditch the :using => :nounzip extra.

[ilovezfs]

Hmm...
@DomT4 https://github.com/att/ast
It looks like AT&T moved ksh there and updated their build system. But there's no tag. Is there a standard Homebrew way to deal with the situation so that the formula doesn't end up becoming head only, or does an issue just need to be filed requesting a tag? Or I suppose Homebrew could fork the repo directly and make its own tag.

[DomT4]

Is there a standard Homebrew way to deal with the situation so that the formula doesn't end up becoming head only, or does an issue just need to be filed requesting a tag?

Yeah, we file an Issue asking for a tag and then since there's mirrors available here we can use one of those whilst linking to the upstream Issue and leave a comment in formula nudging people to change the URL back if/when upstream publishes the tag.

[vszakats]

Would you mind using https://opensource.apple.com/ here? (note the HTTPS and removed www.)

[ilovezfs]

Ah so removing the www is the magic to getting that to work?

[vszakats]

Yes, the certificate only covers the www-less name. It's not best practice, but that's what it is.

[ilovezfs]

@vszakats Done.

[vszakats]

@ilovezfs Looks good, thank you! On a tiny nit: You can safely drop .www from mirrorservice.org as well.

[ilovezfs]

@vszakats I see a massive pull request in your future:

Josephs-MacBook-Pro:Formula joe$ grep -r mirrorservice.org .|wc -l
      68
Josephs-MacBook-Pro:Formula joe$ grep -r mirrorservice.org .|grep www.mirrorservice|wc -l
      25

[DomT4]

Unless there's actual breakage let's not bother going down that path 😄.

[ilovezfs]

@DomT4 I think I'd have bet the farm you were going to say that :)

[vszakats]

@ilovezfs I know about those :) I don't plan to open PRs solely for URL beatifying, but will correct those when there for other reasons (and if I remember it).

[ilovezfs]

@vszakats It would be quite something if URLs could be beatified!

[vszakats]

BTW a worse contender in this regard is sf.net vs sourceforge.net. There are merits in sticking to a single canonical domain to point to the same host (f.e. to help automated scripts), but still not something mandating PRs. So, there is nothing to fear :) Could be an audit thing once every other more important problem is resolved ;)

[DomT4]

Merged in b563391. Thanks again @ilovezfs! 😃

[ilovezfs]

@DomT4 FYI att/ast#3
Also, trying to build with the new upstream led to some spectacular breakage that will require attention at some point.

[DomT4]

Thanks for filing the Issue! The words "spectacular breakage" always fill me with hope and joy 😟

[jens-maus]

@ilovezfs
I wonder if ksh builds for you under MacOSX 10.11.4 with recent Xcode. Here (att/ast#4) I reported some issue in 'nmake' crashing with a buffer overlap error. Have you experienced the same and that's what you call "spectacular breakage"? ;)