This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
git-credential-manager 1.5.0 #50293
Closed
git-credential-manager 1.5.0 #50293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice the dependency has changed for Mac OS X 10.11+
olivierdagenais
force-pushed
the
gcm4ml-1.5.0
branch
from
73ff701
to
17929d6
Compare
olivierdagenais
changed the title
|
|
||
| bottle :unneeded | ||
|
|
||
| depends_on :java => "1.7+" | ||
| depends_on :java => "1.8+" if MacOS.version >= :el_capitan |
There was a problem hiding this comment.
You can make this a single block conditional rather than two:
if MacOS.version >= :el_capitan
depends_on :java => "1.8+"
else
depends_on :java => "1.7+"
endThere was a problem hiding this comment.
You can make this a single block conditional
Done in 346d83d.
|
Merged in cd9b382. Thank you for another contribution to Homebrew @olivierdagenais! 😺 |
xu-cheng
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Mar 22, 2016
Notice the dependency has changed for Mac OS X 10.11+ Closes Homebrew/legacy-homebrew#50293. Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
benjaminfrank
pushed a commit
to benjaminfrank/homebrew
that referenced
this pull request
Apr 9, 2016
Notice the dependency has changed for Mac OS X 10.11+ Closes Homebrew#50293. Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice the dependency has changed for Mac OS X 10.11+
To see the testing that was performed, refer to microsoft/Git-Credential-Manager-for-Mac-and-Linux#32