This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
citus 5.0.1 (new formula) #50392
Closed
citus 5.0.1 (new formula) #50392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmp85
added a commit
to citusdata/packaging
that referenced
this pull request
Mar 24, 2016
Pending an upstream pull request (Homebrew/legacy-homebrew#50392), I'll keep this updated for anyone who might have this repo tapped.
jasonmp85
force-pushed
the
add_citus_formula
branch
2 times, most recently
from
fb4dc1a
to
63d4436
Compare
jasonmp85
added a commit
to citusdata/packaging
that referenced
this pull request
Mar 24, 2016
Pending an upstream pull request (Homebrew/legacy-homebrew#50392), I'll keep this updated for anyone who might have this repo tapped.
| depends_on "postgresql" | ||
|
|
||
| def install | ||
| config_args = %W[--prefix=#{prefix} PG_CONFIG=#{Formula["postgresql"].opt_bin}/pg_config] |
There was a problem hiding this comment.
For pg_config can it be set as an environment variable instead? Like
ENV["PG_CONFIG"] = Formula["postgresql"].opt_bin}/"pg_config"There was a problem hiding this comment.
I can see if that would work.
Today Citus Data announced they "unforked" their PostgreSQL-based dist- ributed database and open-sourced the whole project. This means Citus, previously a private fork of the PostgreSQL codebase, can now be added to an existing PostgreSQL install using the standard PostgreSQL CREATE EXTENSION command. This is analogous to e.g. PostGIS, whose formula was used as an example when writing the formula for Citus. Other PostgreSQL-related formula provided good examples of a test block that actually starts PostgreSQL and verifies installation of the extension.
jasonmp85
force-pushed
the
add_citus_formula
branch
from
63d4436
to
742611e
Compare
ghost
removed
the
Sets pg_config using an environment variable, removes all configure arguments, and moves the make arguments inline.
We've released a newer version since the original code review; might as well update.
|
@dunn — I addressed your feedback (checklist up top) and updated the Citus version. The Shall I reopen this under the new repo (I will unless you object)? |
|
Closing in favor of the new Homebrew/homebrew-core#463. |
apjanke
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Apr 20, 2016
Last month, Citus Data "unforked" Citus, their PostgreSQL-based dist- ributed database and open-sourced the whole project. This means Citus, previously a private fork of the PostgreSQL codebase, can now be added to an existing PostgreSQL install using the standard PostgreSQL CREATE EXTENSION command. This is analogous to e.g. PostGIS, whose formula was used as an example when writing the formula for Citus. Other PostgreSQL-related formula provided good examples of a test block that actually starts PostgreSQL and verifies installation of the extension. Previously submitted as Homebrew/legacy-homebrew#50392, where it has already undergone some code review. Closes #463. Signed-off-by: Andrew Janke <andrew@apjanke.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today Citus Data announced they "unforked" their PostgreSQL-based distributed database and open-sourced the whole project. This means Citus, previously a private fork of the PostgreSQL codebase, can now be added to an existing PostgreSQL install using the standard PostgreSQL CREATE EXTENSION command.
This is analogous to e.g. PostGIS, whose formula was used as an example when writing the formula for Citus. Other PostgreSQL-related formula provided good examples of a test block that actually starts PostgreSQL and verifies installation of the extension.
Code Review Tasks
pg_configusing environment variablemakeandconfigureargs inline to the relevantsystemcalls