Conversation
url "http://www.hampa.ch/pub/pce/pre/pce-20140222-4b05f0c.tar.gz" | ||
sha256 "44edaf071bb6840b6b3336174d528ff10c4dba8cb38194f0289fda81ac34f57f" | ||
url "http://www.hampa.ch/pub/pce/pre/pce-20160308-72f1e10.tar.gz" | ||
version "0.2.2+20160308" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably going to be computed as a lower version than the previous, so we should probably leave it scanned from the URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They seem to alternate version schemes between stable and unstable versions. For example, they had 20130218
between 0.2.1
and 0.2.2
. I know prefixing version in this way may break some existing users for now, but the current devel version will prevent upgrading to stable versions later anyways. Another thing is that version scanning didn't work correctly with their filenames. The version was supposed to be 20140222
, but was set to 20140222-4
due to the following hash part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if upstream alternates their version scheme, we can always use the date. Would that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that we would use the date for even stable versions? I thought the other way around. We could always use numerics (0.x.x) and optionally add date for unstable release. The current formula already uses stable version 0.2.2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or does brew distinguish versions between stable and devel? i.e. no upgrade from devel to stable even if higher stable versions available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or does brew distinguish versions between stable and devel? i.e. no upgrade from devel to stable even if higher stable versions available?
Yep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new thing that I just learned! Okay, the formula is updated to conform the current scheme.
Merged as Homebrew/homebrew-core@4c859fc, thanks again! |
All Submissions:
New Formulae Submissions:
brew audit --strict --online <formula>
(where<formula>
is the name of the formula you're submitting)?brew install <formula>
?