Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

pce 20160308 (devel) #50593

Closed
wants to merge 1 commit into from
Closed

pce 20160308 (devel) #50593

wants to merge 1 commit into from

Conversation

tomyun
Copy link
Contributor

@tomyun tomyun commented Apr 1, 2016

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Formulae Submissions:

  • Does your submission pass
    brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting)?
  • Have you built your formula locally prior to submission with brew install <formula>?

url "http://www.hampa.ch/pub/pce/pre/pce-20140222-4b05f0c.tar.gz"
sha256 "44edaf071bb6840b6b3336174d528ff10c4dba8cb38194f0289fda81ac34f57f"
url "http://www.hampa.ch/pub/pce/pre/pce-20160308-72f1e10.tar.gz"
version "0.2.2+20160308"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably going to be computed as a lower version than the previous, so we should probably leave it scanned from the URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They seem to alternate version schemes between stable and unstable versions. For example, they had 20130218 between 0.2.1 and 0.2.2. I know prefixing version in this way may break some existing users for now, but the current devel version will prevent upgrading to stable versions later anyways. Another thing is that version scanning didn't work correctly with their filenames. The version was supposed to be 20140222, but was set to 20140222-4 due to the following hash part.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if upstream alternates their version scheme, we can always use the date. Would that work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that we would use the date for even stable versions? I thought the other way around. We could always use numerics (0.x.x) and optionally add date for unstable release. The current formula already uses stable version 0.2.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does brew distinguish versions between stable and devel? i.e. no upgrade from devel to stable even if higher stable versions available?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does brew distinguish versions between stable and devel? i.e. no upgrade from devel to stable even if higher stable versions available?

Yep!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new thing that I just learned! Okay, the formula is updated to conform the current scheme.

@dunn
Copy link
Contributor

dunn commented Apr 2, 2016

Merged as Homebrew/homebrew-core@4c859fc, thanks again!

@tomyun tomyun deleted the pce-20160308 branch April 2, 2016 20:31
@apjanke apjanke modified the milestone: Clear out Legacy May 3, 2016
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants