Add formulae for {lib,}mp3splt (new)

[npinto]

With one commit per formula.

[mblair]

+1

[jacknagel]

Preferred way to do this is

ENV.append 'ACLOCAL_FLAGS', '-I/usr/local/share/aclocal'
system "./autogen.sh"

(the formula installer forks, so no need to worry about contaminating the parent environment).

[npinto]

Thanks @jacknagel, I've merged your code suggestions.

[jacknagel]

Thanks, I know this formula has been cooking in some form for quite a while now, so I'll try to give it a proper review tomorrow.

[jacknagel]

Pulled, thanks for your patience.

[npinto]

Thanks a ton!

[marton78]

HI, libmp3splt fails to build with the following errors:

==> Downloading http://downloads.sourceforge.net/project/mp3splt/libmp3splt/0.6.1a/libmp3splt-0.6.1a.tar.gz
==> Patching
patching file autogen.sh
patch unexpectedly ends in middle of line
Hunk #2 succeeded at 46 with fuzz 1.
==> ./autogen.sh
==> autoconf
configure.ac:38: error: possibly undefined macro: AM_INIT_AUTOMAKE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:40: error: possibly undefined macro: AM_MAINTAINER_MODE
configure.ac:57: error: possibly undefined macro: AM_GNU_GETTEXT
configure.ac:58: error: possibly undefined macro: AM_GNU_GETTEXT_VERSION
configure.ac:77: error: possibly undefined macro: AC_PROG_LIBTOOL
configure.ac:79: error: possibly undefined macro: AC_WITH_LTDL
configure.ac:85: error: possibly undefined macro: AM_CONDITIONAL
configure.ac:121: error: possibly undefined macro: AC_MSG_WARN
configure.ac:128: error: possibly undefined macro: AC_MSG_ERROR
configure.ac:200: error: possibly undefined macro: AC_CHECK_CUTTER
==> Exit Status: 1
http://github.com/mxcl/homebrew/blob/master/Library/Formula/libmp3splt.rb#L23

Seems like ENV.append 'ACLOCAL_FLAGS', '-I/usr/local/share/aclocal' doesn't work. Any idea what's going on?

Marton

[npinto]

Can you try with system "ACLOCAL_FLAGS=\"-I /usr/local/share/aclocal $ACLOCAL_FLAGS\" ./autogen.sh" instead ? I believe this line is only useful for autogen.sh but makes autoconf crash.

[marton78]

unfortunately, the problem still persists:

Hunk #2 succeeded at 46 with fuzz 1.
==> ACLOCAL_FLAGS="-I /usr/local/share/aclocal $ACLOCAL_FLAGS" ./autogen.sh
==> autoconf
configure.ac:38: error: possibly undefined macro: AM_INIT_AUTOMAKE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:40: error: possibly undefined macro: AM_MAINTAINER_MODE
configure.ac:57: error: possibly undefined macro: AM_GNU_GETTEXT
configure.ac:58: error: possibly undefined macro: AM_GNU_GETTEXT_VERSION
configure.ac:77: error: possibly undefined macro: AC_PROG_LIBTOOL
configure.ac:79: error: possibly undefined macro: AC_WITH_LTDL
configure.ac:85: error: possibly undefined macro: AM_CONDITIONAL
configure.ac:121: error: possibly undefined macro: AC_MSG_WARN
configure.ac:128: error: possibly undefined macro: AC_MSG_ERROR
configure.ac:200: error: possibly undefined macro: AC_CHECK_CUTTER
==> Exit Status: 1
http://github.com/mxcl/homebrew/blob/master/Library/Formula/libmp3splt.rb#L22

Just to make sure I didn't misunderstand you, the formula looks like:

  def install
    system "ACLOCAL_FLAGS=\"-I /usr/local/share/aclocal $ACLOCAL_FLAGS\" ./autogen.sh"
    system "autoconf"

[npinto]

What is the content of your ```/usr/local/share/aclocal?

This may be related to commit 0301f4d.

[jacknagel]

Do you have Homebrew installed somewhere other than /usr/local?

I just realized that this:

ENV.append 'ACLOCAL_FLAGS', '-I/usr/local/share/aclocal'

should be

ENV.append 'ACLOCAL_FLAGS', "-I#{HOMEBREW_PREFIX}/share/aclocal"

will fix in a minute.

[npinto]

Also, are you permissions set correctly for /usr/local ? If not, a sudo chown -R $USER /usr/local might help.

[marton78]

Thanks for your help! Homebrew is in /usr/local. However, I had some old broken symlinks in /usr/local/share/aclocal from an old homebrew installation, deleting them helped! Maybe brew doctor should look for this issue.

Now compilation fails with libtool: link: cannot find the library ../libltdl/libltdlc.la'`. Indeed there is no "libltd*" in /usr/local...

[jacknagel]

Please open a new issue, posting all relevant information (i.e., read the new issue checklist on the wiki).