mp4v2: Upgrade to r479

[2bits]

This is a recommended upgrade for mp4v2 from the maintainers who
point to a forum exchange where they mention that the previous
version 1.9.1 was more of an experiment to test the release code.
They go on to state on their homepage that this is the version
to use. It has been out for three months now. It compiles
and runs without error using llvm-2335, gcc-4.2.1, and clang-2.0
on OSX 10.6.8 64bit kernel. It makes native static and shared
libraries. The --disable-dependency-tracking was removed because
it is the default behavior. This commit also installs the man
pages, and includes a def test that just outputs version info,
because there are no mp4 files around for testing. This is a
library for handling mp4 and m4v video containers.

[adamv]

This breaks compiling cmus:

mp4.c: In function 'mp4_open':
mp4.c:121: error: too many arguments to function 'MP4Read'
mp4.c:169: error: too few arguments to function 'MP4Close'
mp4.c: In function 'mp4_close':
mp4.c:183: error: too few arguments to function 'MP4Close'
make: *** [mp4.lo] Error 1
make: *** Waiting for unfinished jobs....

[2bits]

ok.

[weisslj]

This error is fixed by commit https://gitorious.org/cmus/cmus/commit/0f87d00831271c9c6f44a2ae683d50b1a46e5a6f . But maybe/probably a new maintenance version will be released soon, so the patch would not need to be included...

[weisslj]

Has this been merged? cmus 2.4.3 got commited in #8916

[adamv]

This has not been merged; will there be other compatibility problems?

I guess only cmus and easy-tag are currently using this.

[weisslj]

I don't know if there are any other compatibility problems... and I can't test it (no mac).

[2bits]

It works for cmus now, but it breaks easy-tag with API errors during compile:

mp4_header.c: In function ‘Mp4_Header_Read_File_Info’:
mp4_header.c:207: error: too many arguments to function ‘MP4Read’
mp4_header.c:221: error: too few arguments to function ‘MP4Close’
mp4_header.c:246: error: too few arguments to function ‘MP4Close’
make[3]: *** [mp4_header.o] Error 1

[jacknagel]

Any movement on this? I see the easy-tag formula was updated at the beginning of March.

[adamv]

mp4_header.c: In function ‘Mp4_Header_Read_File_Info’:
mp4_header.c:207: error: too many arguments to function ‘MP4Read’
mp4_header.c:221: error: too few arguments to function ‘MP4Close’
mp4_header.c:246: error: too few arguments to function ‘MP4Close’

[2bits]

I just gave easy-tag a shot. No joy. Cmus works though and plays m4a from iTunes. So maybe what we need is a devel block for this. That way cmus can work and so can easy-tag?

[jacknagel]

I'd agree. I see MacPorts has r479 as a devel port.

[braidn]

Just as a heads up of sorts, yes, seeing this on a cmus install.

[2bits]

I just crafted the new formula, but I don't have my branch locally or on Github anymore. It works well though, the devel version, for easy-tag. Without it, people can't open anything from iTunes because they are all .m4a tracks. I also had success with cmus like @bradendouglass reported (thanks!). Unless @jacknagel knows another way, I'll make the new pull request in a few hours.

I have to use two patches that exist in r479 but are needed in the stable to fix compile errors with clang. At the moment I have them inline, but I was hoping to pull them directly off their code base. I can't find a raw diff for this patch though.

[2bits]

I figured how to make a diff using svn but never found a direct link on GoogleCode for one. New pull otw.