Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HB2-93 make prediction for activity types too #94

Merged
merged 13 commits into from Dec 1, 2020
Merged

Conversation

drixselecta
Copy link
Collaborator

@drixselecta drixselecta commented Nov 20, 2020

Provide realistic schedule estimations for unlogged users: fixes #93

  • Only propose activity types in forms for which the athlete has a prediction model
  • Calculate realistic defaults for all activity types with activities
  • Cleanup existing activities, delete the ones that don't have corresponding Strava activities
  • The only way to create a new activity type is by importing a corresponding Strava activity

@coveralls
Copy link

coveralls commented Nov 20, 2020

Pull Request Test Coverage Report for Build 849

  • 147 of 150 (98.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 98.927%

Changes Missing Coverage Covered Lines Changed/Added Lines %
homebytwo/routes/models/activity.py 83 84 98.81%
homebytwo/routes/fields.py 4 6 66.67%
Totals Coverage Status
Change from base Build 838: -0.05%
Covered Lines: 2306
Relevant Lines: 2331

💛 - Coveralls

@drixselecta drixselecta merged commit c95e58d into master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve default predictions for activity types
2 participants