Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify config and install? #4

Closed
pjf opened this issue Sep 28, 2014 · 0 comments · Fixed by #5
Closed

Simplify config and install? #4

pjf opened this issue Sep 28, 2014 · 0 comments · Fixed by #5

Comments

@pjf
Copy link
Contributor

pjf commented Sep 28, 2014

Hey HoneyFox!

I love your work, but I've always found it a little tricky needing to figure which configs to extract from the PressurizedFT and Ignitor Configs files.

I was wondering if we'd be able to simplify things? I know that ModuleManager these days allows for :NEEDS and :AFTER configs, so it strikes me that we can install all the ignitor configs and pressurized tanks by default, and by using appropriate MM filters only have them apply if the required parts packs are installed. This would greatly simply installation to unzip into GameData.

I'm not familiar with the ignitor configs provided by RealFuels, but if there's always a single way this should be done (ie, always use RF configs if installed), then we should be able to do the same here. (Mentioning @NathanKell in case of any RF insights.)

I do have an ulterior motive, which is that I want to be able to test EngineIgnitor as part of my work on the CKAN, and embedded zip files unfortunately cause troubles when it comes to automated installs.

Many thanks again for all your great work!

~ Paul
pjf added a commit to pjf/EngineIgnitor that referenced this issue Nov 2, 2014
@pjf
Mark all MM changes as :FOR[EngineIgnitor]:NEEDS[!RealismOverhaul]
98ae946 
For HoneyFox#4.
Closes HoneyFox#4.
pjf added a commit to pjf/EngineIgnitor that referenced this issue Nov 2, 2014
@pjf
Mark all MM changes as :FOR[EngineIgnitor]:NEEDS[!RealismOverhaul]
2f78596 
This means we should be able to bundle all these configs with the standard module install, rather than needing the user to find and unzip files.

Closes HoneyFox#4.
Unblocks KSP-CKAN/CKAN-Meta#11
Unblocks KSP-CKAN/CKAN-Meta#12
@pjf pjf mentioned this issue Nov 2, 2014
Merged
pjf added a commit to pjf/EngineIgnitor that referenced this issue Nov 2, 2014
@pjf
Mark all MM changes as :FOR[EngineIgnitor]:NEEDS[!RealismOverhaul]
b60dcd3 
This means we should be able to bundle all these configs with the standard module install, rather than needing the user to find and unzip files.

Closes HoneyFox#4.
Unblocks KSP-CKAN/CKAN-Meta#11
Unblocks KSP-CKAN/CKAN-Meta#12
pjf added a commit to pjf/EngineIgnitor that referenced this issue Nov 3, 2014
@pjf
Tagged all ignitor configs with :FOR[EngineIgnitor]:NEEDS[!RealismOve…
290d8bb 
…rhaul]

Identical to HoneyFox#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark all MM changes as :FOR[EngineIgnitor]:NEEDS[!RealismOverhaul] pjf/EngineIgnitor
1 participant
@pjf