WebDriver Extension API: Do some proof-reading #2
Conversation
webdriver-extension/index.bs
Outdated
| @@ -453,8 +452,8 @@ The <a>remote end steps</a> are: | |||
| </tbody> | |||
| </table> | |||
|
|
|||
| The <dfn>get mock sensor</dfn> <a>extension command</a> simulates user | |||
| getting information of a given type of [=mock sensor=]. | |||
| The <dfn>get mock sensor</dfn> <a>extension command</a> simulates | |||
There was a problem hiding this comment.
Quote conversations with @JohnChen0:
John: The word "simulates" seems wrong here. This extension command creates a mock sensor, not just simulate creating one.
Wanming: This actually "simulates" user action to create a mock sensor, and there are two instances that use "simulates" in Permission API and Reporting API. Does that make sense to you?
John: Sounds good.
So, if we want to erase user action, we'd better avoid using "simulates".
There was a problem hiding this comment.
I've pushed a new version that removes "simulates" from most places -- I think John's point is that we are really manipulating a (mock) sensor rather than pretend to do that. Let me know if it looks OK now.
|
@rakuco, this is really a great proof-reading, and very appreciate for your such sweet help! |
rakuco
force-pushed
the
webdriver-extension-proof-reading
branch
from
1efb303
to
2e57e0d
Compare
I've done some proof-reading of both
index.bsand the explainer. I figured it'd be easier to just send a PR here instead of pointing out the issues line-by-line in the original pull request :)