Merge pull request #38 from joekrump/update-github-actions

Try running rspec tests on macos-13
HonuLife · Jul 12, 2023 · 2995d76 · 2995d76
2 parents 02c13cf + 6cdfa3a
commit 2995d76
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 21 deletions.
diff --git a/.github/workflows/rubyonrails.yml b/.github/workflows/rubyonrails.yml
@@ -13,22 +13,12 @@ on:
 jobs:
   test-rspec:
     timeout-minutes: 30
-    runs-on: ubuntu-latest
+    runs-on: macos-13
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v3
-      # Add or replace dependency steps here
-      - name: Install Ruby and gems
-        uses: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf # v1.146.0
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
         with:
           bundler-cache: true
-      - name: Setup SQLite environment
-        # You may pin to the exact commit or the version.
-        # uses: ccorsi/setup-sqlite@90c2ea365856628cdbb502d642b658d9d0fccfab
-        uses: ccorsi/setup-sqlite@v1.0.1
-        with:
-          # The version of SQLite that you want to install, example, 3.40.0
-          sqlite-version: 3.40.0
       - name: Set up database schema
         run: bin/rails db:schema:load
       - name: Cache yarn packages
@@ -55,7 +45,8 @@ jobs:
         with:
           path: |
             ~/.cache/ms-playwright
-          key: "${{ runner.os }}-playwright-v6-${{env.PLAYWRIGHT_VERSION}}"
+            /Users/runner/Library/Caches/ms-playwright
+          key: "${{ runner.os }}-playwright-v7-${{env.PLAYWRIGHT_VERSION}}"
       - name: Install Playwright Browsers
         if: steps.playwright-cache.outputs.cache-hit != 'true'
         run: npx playwright install --with-deps chromium
@@ -100,10 +91,8 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v3
-      - name: Install Ruby and gems
-        uses: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf # v1.146.0
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
         with:
           bundler-cache: true
       # Add or replace any other lints here

diff --git a/spec/system/home_spec.rb b/spec/system/home_spec.rb
@@ -9,7 +9,7 @@
     expect(actual_screenshot_path)
       .to match_screenshot(
         expected_screenshot_path(suffix: nil),
-        max_threshold_pct: 1.4
+        max_threshold_pct: 2.4
       )
   end
 end
diff --git a/spec/system/pandas/index_spec.rb b/spec/system/pandas/index_spec.rb
@@ -20,7 +20,7 @@
       expect(actual_screenshot_path)
         .to match_screenshot(
           expected_screenshot_path(suffix: nil),
-          max_threshold_pct: 2.8
+          max_threshold_pct: 2.4
           # update: true # Uncomment this whenever you want to update the expected screenshot
         )
 
@@ -32,7 +32,7 @@
       expect(actual_screenshot_path(suffix: 'dark'))
         .to match_screenshot(
           expected_screenshot_path(suffix: 'dark'),
-          max_threshold_pct: 2.8
+          max_threshold_pct: 2.4
         )
     end
   end