Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG path command T does not update the control point correctly #1443

Open
2 tasks done
ralfstx opened this issue Apr 23, 2023 · 0 comments · Fixed by cantoo-scribe/pdf-lib#30
Open
2 tasks done

SVG path command T does not update the control point correctly #1443

ralfstx opened this issue Apr 23, 2023 · 0 comments · Fixed by cantoo-scribe/pdf-lib#30

Comments

@ralfstx
Copy link

ralfstx commented Apr 23, 2023

What were you trying to do?

Drawing using drawSvgPath ...

How did you attempt to do it?

... with this path: M 10,25 Q 30,0 50,25 Q 70,50 90,25 T 130,25 T 170,25.

What actually happened?

image

What did you expect to happen?

The green line in the image above, instead the red line is rendered.

How can we reproduce the issue?

drawSvgPath('M 10,25 Q 30,0 50,25 Q 70,50 90,25 T 130,25 T 170,25')

Version

1.17.1

What environment are you running pdf-lib in?

Node

Checklist

  • My report includes a Short, Self Contained, Correct (Compilable) Example.
  • I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes

No response

ralfstx added a commit to ralfstx/pdf-lib that referenced this issue Apr 23, 2023
The control point (`px`, `py`) is already updated in the else branch
above (L271). It is then updated once again which causes bug Hopding#1443.

This commit removes these duplicated lines which fixes the bug.
ralfstx added a commit to ralfstx/pdf-lib that referenced this issue Oct 2, 2023
The control point (`px`, `py`) is already updated in the else branch
above (L271). It is then updated once again which causes
Hopding#1443

This commit removes these duplicated lines which fixes the bug.
ralfstx added a commit to ralfstx/pdf-lib that referenced this issue Oct 2, 2023
The control point (`px`, `py`) is already updated in the else branch
above (L271). It is then updated once again which causes
Hopding#1443

This commit removes these duplicated lines which fixes the bug.
Sharcoux pushed a commit to cantoo-scribe/pdf-lib that referenced this issue Oct 3, 2023
The control point (`px`, `py`) is already updated in the else branch
above (L271). It is then updated once again which causes
Hopding#1443

This commit removes these duplicated lines which fixes the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant