New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom font name on embed #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ztoben This looks great! Thanks for working on this. I've just requested a few small changes.
In addition to the review comments, I would like the customName
functionality to be supported by all font embedders, including StandardFontEmbedder
. This keeps things predictable and consistent, even if it isn't strictly necessary. So, if you don't mind, please take a look at adding this as well.
@Hopding I think I addressed all of your comments. Let me know if there's any other changes to be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ztoben Just a couple more small changes, then we should be good to go 👍
@Hopding okay, let's try this again 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks again @ztoben 👍
This feature will be available in the next release. I'm planning to cut it this weekend. |
Version You can install this new version with npm:
It's also available on unpkg:
As well as jsDelivr: |
* allow custom font name on embed * linting * customFontName -> customName, additional testing around font embedding * address additional comments * remove console log
* allow custom font name on embed * linting * customFontName -> customName, additional testing around font embedding * address additional comments * remove console log
As discussed in #537 this allows the use of a custom font name so that we can have a predictive binary output when embedding fonts into the pdf. Happy to make any changes you deem necessary.