error handling logic for inference runs #320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have the problem where a single failure in one of the child jobs will cause the parent job for a run to be marked as failed, which prevents the copy job from running during the last phase of the pipeline. A small number of child job failures isn't actually a problem for us, so I'm adding a handler function that will:
To prevent the problem where every job we run fails but gets marked as succeeding, I'm adding a check to the start of each inference run that will count up the number of failure indicator files in the failure indicator directory, and if it is greater than 10, every job in the run will fail.
Note that a consequence of this change is that some inference runs will re-start from scratch again after an initial failure, which will mean that some slots will have been generated using fewer sims than other slots. I'm not sure of the right way to handle this, but I'm assuming that dropping that slot entirely is an acceptable fallback.