Made changes to support easily building and running on Mac #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0guslaw
suggested changes
Feb 13, 2020
There was a problem hiding this comment.
The changes made to client.cpp should belong in their own commit. If the changes in made in client.cpp are solely connected to the underlying operating system I suggest keeping the "old" method and wrapping the newly introduced method into a platform dependent ifdef statement with a brief comment explaining the methodology.
This feedback is purely made for aesthetic choices. When someone glances at the latest commits it should not confuse them when client.cpp was touched for "easily building and running on mac"
grant-rez
force-pushed
the
MacSupport
branch
from
7b281e5
to
661f956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified several areas to make things work on mac. I had to change the way that the mouse was working because the game was not responding correctly when I used a track pad or a connected mouse.