Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain separation to msgToSign #104

Merged
merged 18 commits into from
Jan 20, 2023
Merged

Add domain separation to msgToSign #104

merged 18 commits into from
Jan 20, 2023

Conversation

mikelodder7
Copy link
Contributor

No description provided.

@DanieleDiBenedetto DanieleDiBenedetto changed the base branch from development to audit_fixes_2023 January 13, 2023 09:05
DanieleDiBenedetto
DanieleDiBenedetto requested changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@DanieleDiBenedetto DanieleDiBenedetto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Apart from some minor comments. Don't forget to update the circuits regression test before closing this

demo-circuit/src/naive_threshold_sig_w_key_rotation/data_structures.rs Outdated Show resolved Hide resolved
demo-circuit/src/naive_threshold_sig_w_key_rotation/data_structures.rs Show resolved Hide resolved
demo-circuit/src/naive_threshold_sig_w_key_rotation/data_structures.rs Outdated Show resolved Hide resolved
demo-circuit/src/naive_threshold_sig_w_key_rotation/data_structures.rs Show resolved Hide resolved
demo-circuit/src/naive_threshold_sig_w_key_rotation/constraints/data_structures.rs Outdated Show resolved Hide resolved
jni/src/main/java/com/horizen/certnative/NaiveThresholdSignatureWKeyRotation.java Outdated Show resolved Hide resolved
api/src/lib.rs Outdated Show resolved Hide resolved
demo-circuit/src/naive_threshold_sig_w_key_rotation/tests/verify.rs Outdated Show resolved Hide resolved
demo-circuit/src/naive_threshold_sig_w_key_rotation/tests/verify.rs Show resolved Hide resolved
demo-circuit/src/naive_threshold_sig_w_key_rotation/tests/verify.rs Outdated Show resolved Hide resolved
@DanieleDiBenedetto DanieleDiBenedetto marked this pull request as ready for review January 13, 2023 14:18
@DanieleDiBenedetto DanieleDiBenedetto changed the title New methods for hashing key updates Add domain separation to msgToSign Jan 13, 2023
@DanieleDiBenedetto
Copy link
Collaborator

@i-Alex if you or someone else wants to take a look at the Java part, please do :)

@i-Alex i-Alex requested review from sgonta and i-Alex January 13, 2023 17:43
i-Alex
i-Alex approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@i-Alex i-Alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@DanieleDiBenedetto from SDK perspective seems fine, you may proceed with the merge and snapshot publishing.

@nicholas-mainardi nicholas-mainardi merged commit 303cf31 into audit_fixes_2023 Jan 20, 2023
@DanieleDiBenedetto DanieleDiBenedetto deleted the ml/ps-206 branch March 23, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-mainardi nicholas-mainardi nicholas-mainardi approved these changes

@i-Alex i-Alex i-Alex approved these changes

@DanieleDiBenedetto DanieleDiBenedetto DanieleDiBenedetto approved these changes

@sgonta sgonta sgonta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikelodder7 @DanieleDiBenedetto @i-Alex @nicholas-mainardi @sgonta