Fix cargo audit to catch advisory where information is set to unsound and yanked crates #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added SNAPSHOT[0-9]*.\.jar build and publish + set version script * New CI/CD pipeline process
fixes issue 89
Co-authored-by: nicholas mainardi <mainardinicholas@gmail.com> Co-authored-by: DanieleDiBenedetto <daniele@horizenlabs.io> Co-authored-by: Carlo Russo <carlo.russo@email.it>
New Key Rotation Circuit + Java API updates
…merging/rebasing at some point)
Restored backward compatibility on ThresholdV1 + added related regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cargo audit to catch advisory where information is set to unsound and yanked crates
We added audit.toml to configure cargo audit to catch this kind of warning and expose them as errors. We ignored a atty unsound error because we use atty just for banches and test logging.
More we removed the hack in the check script that relayed on json output and not on cargo audit script output values.
closes(partially): PS-231 https://horizenlabs.atlassian.net/browse/PS-231