PS-217: Implement the circuit for SC2SC verification #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanieleDiBenedetto
requested changes
Jan 30, 2023
DanieleDiBenedetto
approved these changes
Jan 31, 2023
demo-circuit/src/test_utils.rs
Outdated
| } | ||
|
|
||
| impl CommitmentHelper { | ||
| pub(crate) fn add_random_forward_transert_to_sc( |
There was a problem hiding this comment.
Mmm don't see it changed
demo-circuit/src/test_utils.rs
Outdated
| }); | ||
| } | ||
|
|
||
| pub(crate) fn add_random_backward_transert_to_sc( |
There was a problem hiding this comment.
Don't see it changed
|
Should be done now... THX 👀 |
DanieleDiBenedetto
approved these changes
Jan 31, 2023
nicholas-mainardi
force-pushed
the
sc2sc
branch
from
9513669
to
5556b6a
Compare
nicholas-mainardi
force-pushed
the
sc2sc
branch
from
e2720af
to
1df03ee
Compare
DanieleDiBenedetto
approved these changes
Mar 21, 2023
DanieleDiBenedetto
approved these changes
May 16, 2023
to reuse some utilities in tests from other circuits.
ScCommitmentPath and simplified the tests that now fail all with the same message
it by hand and removed the _man in the middle_ enforce_message_path() . implemented check_membership() also for ScCommitmentCertPathGadget: a more idionatic way to define it.
RandomWithdrawalCertificateDataBuilder to build WithdrawalCertificateData for a generic Rng
- transfert -> transfer - widthdrawal -> withdrawal
check the minimum number of custom fields. Add also test and removed the hardcoded 3: replaced it with MSG_MT_HEIGHT everywhere
Implement Sc2Sc jni interface
Add ScCommitmentCertPath.updateScCommitmentPath() to handle the case where sdk can just rebuilt the sidechain tree but not the complete commitment tree.
- Fixed TYPOS - Renamed variable to use the same notation used in design documents - Don't point to outdated doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This circuit follow the specifications in ZenIP-42205 and tests use
cctp_primitives::commitment_tree::CommitmentTreeto build a valid states tree.BTW I did a little refactor to reuse some utilities in tests from other circuits. I've introduced some structs to simplify the tests for this circuit but I avoided to refactor the other circuits tests and use the newer utilities ... That can be done later in another PR if we prefer.