Italics added and bold improvised #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horizon733
added
enhancement
Horizon733
requested changes
Oct 12, 2021
Comment on lines
+90
to
+93
| """font_file_exists, message = path_exist(font_file_path, True) | ||
| if not font_file_exists: | ||
| click.echo(f"Error: {message}") | ||
| return | ||
| return""" |
There was a problem hiding this comment.
We could just use default one's right when the font file is not accessible
There was a problem hiding this comment.
As the default font in PIL cannot be resized, I have added a default font in the click.option itself for the font file path if user doesn't explicitly define a font poth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options to italicize text, improvised the bold option too using font selection. By default it'll use a proprietary font, unless explicitly defined by the font-file-path tag. This PR resolves #2