Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Doesn't fit terminal size #63

Closed
SomethingGeneric opened this issue Apr 26, 2020 · 8 comments · Fixed by #64
Closed

[BUG] Doesn't fit terminal size #63

SomethingGeneric opened this issue Apr 26, 2020 · 8 comments · Fixed by #64
Labels
bug 🐛 A real glitch has been found
Projects
Core
Milestone
v4.7.2

Comments

@SomethingGeneric
Copy link
Contributor

Describe the bug
Some lines of archey system info wrap to next line on Ubuntu 20.04 80col x 24row

Expected behavior
Regular system info display

Screenshots
(note: "Reminders" is my own program. I'm talking about archey above it.)
Screenshot from 2020-04-26 14-35-27

Environment

  • Version used (4.Y.Z) : 4.7.1
  • Method of installation (distribution package, PyPI, sources) : .deb package
  • Hardware type (laptop, server, Raspberry, hyper-visor) : Custom built desktop tower
  • Python version (3.Y.Z) : 3.8.2
  • Operating system and version : Ubuntu 20.04
  • Graphical environment name and version : Gnome 3.34 (I think, per Ubuntu "Software")
  • Connectivity (off-line, LAN only, Internet access) : Ethernet access

Additional context
Just installed 20.04 "the debian way" so maybe this is a OS issue, but I figured I'd report anyway.
@SomethingGeneric
Copy link
Contributor Author

I just made 100% sure that my own program is not the issue. Still could potentially be any number of things w/ the new Ubuntu release.

@ingrinder ingrinder added the bug 🐛 A real glitch has been found label Apr 26, 2020
@HorlogeSkynet
Copy link
Owner

Hi, thanks for your report !
It's actually a "known-bug", and "officially" since... this morning.

We'll be working on this soon, bye 👋

@HorlogeSkynet HorlogeSkynet added this to the v4.7.2 milestone Apr 26, 2020
@HorlogeSkynet HorlogeSkynet added this to IN PROGRESS in Core Apr 26, 2020
@ingrinder
Copy link
Collaborator

I've pushed some output changes I was working on yesterday to rework/output which should enable the wrapping that @HorlogeSkynet mentioned in the comment this morning a lot easier - I believe it should now be possible to wrap to the terminal size reported by os.get_terminal_size. I'll let you know in a few minutes 😄

@SomethingGeneric
Copy link
Contributor Author

@ingrinder glad to hear it!

ingrinder added a commit that referenced this issue Apr 26, 2020
@ingrinder
Fix #63 - Add text-wrapping to Output
e5dca9d 
Simply adds some code to wrap text to the terminal size before we output
it.
@ingrinder
Copy link
Collaborator

@SomethingGeneric is this the behaviour you'd like? Here's how my output looks at 80x24 with commit e5dca9d above.

image

I'm thinking it could be possible to wrap lines and display them underneath, but a lot harder, so if this truncation with a ... is fine we can stick with that 😃

@SomethingGeneric
Copy link
Contributor Author

@ingrinder that's perfect! I don't particularlly care myself about having my IP's show (since I know them), and that's much better than having the lines extend and cut stuff off.

@ingrinder ingrinder mentioned this issue Apr 26, 2020
Merged
9 tasks
@HorlogeSkynet
Copy link
Owner

Closing here as #64 is on its way. Will be reviewed soon 👌

@HorlogeSkynet HorlogeSkynet moved this from IN PROGRESS to Done in Core Apr 30, 2020
HorlogeSkynet pushed a commit that referenced this issue May 4, 2020
@ingrinder
Reworks the Output class (#64)
4b993d3 
+ Fixes #63 (lines-overlapping in case of undersized terminal)
+ Makes Archey entries inherit from a base (abstract) `Entry` class
+ Allows more than 18 entries to be included in final output
@HorlogeSkynet
Copy link
Owner

Hey @SomethingGeneric ! Sorry for the delay, the patch is now available in the latest release 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 A real glitch has been found
Projects
Core
  
DONE
Milestone
v4.7.2
Development

Successfully merging a pull request may close this issue.

Reworks the Output class HorlogeSkynet/archey4
3 participants
@HorlogeSkynet @SomethingGeneric @ingrinder