Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add option to disable OpenDNS lookups #81

Closed
mrzv opened this issue Jul 4, 2020 · 3 comments · Fixed by #89
Closed

[FEATURE] Add option to disable OpenDNS lookups #81

mrzv opened this issue Jul 4, 2020 · 3 comments · Fixed by #89
Assignees
@HorlogeSkynet
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Projects
Core
Milestone
v4.9.0

Comments

@mrzv
Copy link

mrzv commented Jul 4, 2020

Is your feature request related to a problem? Please describe.
For some reason my employer blocks OpenDNS lookups, so these always timeout causing substantial delays.

Describe the solution you'd like
An option that skips OpenDNS lookup and goes straight for ident.me would solve this problem.
@HorlogeSkynet HorlogeSkynet self-assigned this Jul 5, 2020
@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Jul 5, 2020
@HorlogeSkynet HorlogeSkynet added this to TO DO in Core via automation Jul 5, 2020
@HorlogeSkynet HorlogeSkynet added this to the v4.8.0 milestone Jul 5, 2020
@HorlogeSkynet
Copy link
Owner

HorlogeSkynet commented Jul 5, 2020 •
edited

Hey, I planned to rework WAN_IP once #80 is merged, I'll try to add such a way to configure this behavior at the same time in v4.8.0 v4.9.0 too.
Stay put, see you 👋

@HorlogeSkynet HorlogeSkynet modified the milestones: v4.8.0, v4.9.0 Sep 26, 2020
HorlogeSkynet pushed a commit that referenced this issue Oct 9, 2020
[WAN_IP] Reworks for configuration, DRY and performance purposes
83bd2f9 
+ Fixes IPv6 detection in some particular cases (behind a NAT46)
+ Speeds up `dig` usage failing when no IPv6 are available
+ DNS or HTTP external requests can now be disabled from configuration (fixes #81)
+ DNS or HTTP resolvers can now be changed from configuration
+ Factorizes internal code to DRY
+ DNS and HTTP timeouts are now uncoupled and may be different
@HorlogeSkynet HorlogeSkynet mentioned this issue Oct 9, 2020
Merged
9 tasks
@HorlogeSkynet HorlogeSkynet linked a pull request Oct 9, 2020 that will close this issue
[WAN_IP] Reworks for configuration, DRY and performance purposes #89
Merged
9 tasks
@HorlogeSkynet
Copy link
Owner

HorlogeSkynet commented Oct 9, 2020 •
edited

Hey @mrzv !
Eventually, WAN_IP got reworked. May I ask you to review or even try #89 out ?
As it implies a configuration layout rework too (see #80), you may want to fetch and tweak the new configuration file from the branch itself.

Closing here for the time being as a PR is on its way.

Bye, thanks 🙇

Core automation moved this from TO DO to DONE Oct 9, 2020
HorlogeSkynet pushed a commit that referenced this issue Oct 17, 2020
[WAN_IP] Reworks for configuration, DRY and performance purposes
446293e 
+ Fixes IPv6 detection in some particular cases (behind a NAT46)
+ Speeds up `dig` usage failing when no IPv6 are available
+ DNS or HTTP external requests can now be disabled from configuration (fixes #81)
+ DNS or HTTP resolvers can now be changed from configuration
+ Factorizes internal code to DRY
+ DNS and HTTP timeouts are now uncoupled and may be different

[skip ci]
HorlogeSkynet pushed a commit that referenced this issue Oct 29, 2020
@HorlogeSkynet
[WAN_IP] Reworks for configuration, DRY and performance purposes
2bba326 
+ Fixes IPv6 detection in some particular cases (behind a NAT46)
+ Speeds up `dig` usage failing when no IPv6 are available
+ DNS or HTTP external requests can now be disabled from configuration (fixes #81)
+ DNS or HTTP resolvers can now be changed from configuration
+ Factorizes internal code to DRY
+ DNS and HTTP timeouts are now uncoupled and may be different

[skip ci]
HorlogeSkynet pushed a commit that referenced this issue Nov 22, 2020
[WAN_IP] Reworks for configuration, DRY and performance purposes
feb29e2 
+ Fixes IPv6 detection in some particular cases (behind a NAT46)
+ Speeds up `dig` usage failing when no IPv6 are available
+ DNS or HTTP external requests can now be disabled from configuration (fixes #81)
+ DNS or HTTP resolvers can now be changed from configuration
+ Factorizes internal code to DRY
+ DNS and HTTP timeouts are now uncoupled and may be different

[skip ci]
@HorlogeSkynet
Copy link
Owner

Finally released in v4.9.0.

@HorlogeSkynet HorlogeSkynet mentioned this issue Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HorlogeSkynet HorlogeSkynet

Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Projects
Core
  
DONE
Milestone
v4.9.0
Development

Successfully merging a pull request may close this issue.

[WAN_IP] Reworks for configuration, DRY and performance purposes HorlogeSkynet/archey4
2 participants
@mrzv @HorlogeSkynet