Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Univalent and Moevalent logo #125

Merged
merged 7 commits into from Nov 22, 2022
Merged

Add Univalent and Moevalent logo #125

merged 7 commits into from Nov 22, 2022

Conversation

hayatehay
Copy link
Contributor

Description

Added case for Univalent and Moevalent logo in archey/distributions.py
Created file and added ASCII logo in archey/logos/univalent.py and archey/logos/moevalent.py

Reason and / or context

Add support for Univalent and the derivative, Moevalent.

See also -> https://osdn.net/projects/univalentgnulinux

How has this been tested ?

The operation tests were conducted on both a Virtualbox and dynaobok EX/33J, but no error occurred.

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Nov 21, 2022
@HorlogeSkynet HorlogeSkynet added this to IN PROGRESS in OS, Distributions & Hardware via automation Nov 21, 2022
Copy link
Owner

@HorlogeSkynet HorlogeSkynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Jin-Asanami ! Two comments below :

archey/logos/moevalent.py Outdated Show resolved Hide resolved
archey/logos/univalent.py Outdated Show resolved Hide resolved
@HorlogeSkynet
Copy link
Owner

CI failing due to ubuntu-latest recent bump, see actions/setup-python#543.

@HorlogeSkynet HorlogeSkynet merged commit 676bdc2 into HorlogeSkynet:master Nov 22, 2022
OS, Distributions & Hardware automation moved this from IN PROGRESS to DONE Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Development

Successfully merging this pull request may close these issues.

None yet

2 participants