Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISTROS] Adds support for Nobara #131

Merged
merged 2 commits into from Mar 18, 2023
Merged

[DISTROS] Adds support for Nobara #131

merged 2 commits into from Mar 18, 2023

Conversation

Snootiful
Copy link
Contributor

Description

This PR adds ASCII art for the Nobara Project.
(The ASCII art was not made by me, but using an ASCII art generator. I would like to encourage someone who has experience making ASCII art to improve this icon.)

I have not merged the branch I created with the master branch. As this PR should not cause merge conflicts I will leave the merging to whoever accepts this PR.

Also, the provided screenshots show warnings about temperature sensors. This warning also appears without my changes, because this is an issue with my system. The warnings are not related to the changes this PR makes.

Reason and / or context

This PR was created to support the Nobara Project. The Red Hat logo would show without this PR.

How has this been tested ?

Environment:
Tested this PR on my machine running Nobara 37 using both the fish and bash shell. Should work on other machines too since the code in this PR matches that of other PRs that add logos for various distros.

archey-fish

archey-bash

Built using PEX:

archey-build-pex

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@HorlogeSkynet HorlogeSkynet self-requested a review March 18, 2023 16:13
@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Mar 18, 2023
@HorlogeSkynet HorlogeSkynet added this to IN PROGRESS in OS, Distributions & Hardware via automation Mar 18, 2023
Removes one trailing space from each line of the Nobara logo and remove the Pylint flag to disable the line-too-long warning.
@Snootiful
Copy link
Contributor Author

Thanks for the quick reply :)

The reason I added the Pylint flag and the leading whitespace was because I used the Red Hat logo as reference. I also don't have Pylint installed because I don't often program in Python.

I have removed one space from each line of the logo and removed the Pylint flag as suggested.

@Snootiful
Copy link
Contributor Author

Oh, and I just noticed that I left a trailing comma on the LOGO array, which doesn't follow the code style from PEP8.
My apologies, feel free to remove that comma.

@HorlogeSkynet
Copy link
Owner

Oh, and I just noticed that I left a trailing comma on the LOGO array, which doesn't follow the code style from PEP8.

Don't worry it's actually OK. We use Black code formatter over here, which makes sure there are trailing commas for multiple lines object definitions.

@HorlogeSkynet HorlogeSkynet merged commit 0927889 into HorlogeSkynet:master Mar 18, 2023
OS, Distributions & Hardware automation moved this from IN PROGRESS to DONE Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Development

Successfully merging this pull request may close these issues.

None yet

2 participants