[WAN_IP] Fall back to HTTP properly on DNS connection errors #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just a small change so that if
dig
returns a nonzero exit code, then we don't immediately returnNone
as the IP.Reason and / or context
For example on my home network I block outgoing port 53:
☹️
As you see in this case archey fails to get the IP with the default settings and doesn't fall back to the configured HTTP URL
How has this been tested ?
It now gets my IP and passes the additional test case I added
Types of changes :
Checklist :
[IF NEEDED] I have updated the README.md file accordingly ;[IF BREAKING] This pull request targets next Archey version branch ;