Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Adds (Nerd Fonts) icons for entries #144

Merged
merged 14 commits into from
Jan 14, 2024

Conversation

Tobilike
Copy link
Contributor

@Tobilike Tobilike commented Jan 7, 2024

Possibly all of them have now worked:

Please have a look there:
#141

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
archey/entries/cpu.py Outdated Show resolved Hide resolved
Repository owner deleted a comment from ingrinder Jan 7, 2024
archey/entry.py Outdated Show resolved Hide resolved
@HorlogeSkynet HorlogeSkynet added this to the v4.14.3.0 milestone Jan 8, 2024
@Tobilike
Copy link
Contributor Author

Tobilike commented Jan 10, 2024

I have noticed the following: Integration / Lint Python sources (pull_request)
What exactly is the problem here?

Run black --check --diff archey/
--- /home/runner/work/archey4/archey4/archey/entries/desktop_environment.py	2024-01-10 10:57:56.557093+00:00
+++ /home/runner/work/archey4/archey4/archey/entries/desktop_environment.py	2024-01-10 10:58:29.108694+00:00
@@ -23,10 +23,11 @@
 class DesktopEnvironment(Entry):
     """
     Just iterate over running processes to find a known-entry.
     If not, rely on the `XDG_CURRENT_DESKTOP` environment variable.
     """
+
     _ICON = "\ue23c"  # fae_restore 
     _PRETTY_NAME = "Desktop Environment"
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
would reformat /home/runner/work/archey4/archey4/archey/entries/desktop_environment.py

Oh no! 💥 💔 💥
1 file would be reformatted, 106 files would be left unchanged.
Error: Process completed with exit code 1.

@ingrinder
Copy link
Collaborator

That error is from the code formatter, black - it is saying there should be an additional empty newline after the docstring.

@Tobilike
Copy link
Contributor Author

Thank you. I will always use Black now.

@ingrinder
Copy link
Collaborator

@Tobilike I just pushed a small change, hope that's alright. This LGTM now!

archey/entries/cpu.py Outdated Show resolved Hide resolved
archey/entry.py Outdated Show resolved Hide resolved
archey/entry.py Outdated Show resolved Hide resolved
@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Jan 10, 2024
@HorlogeSkynet HorlogeSkynet added this to IN PROGRESS in Core via automation Jan 10, 2024
@HorlogeSkynet HorlogeSkynet changed the title I add icons #141 [FEATURE] Adds (Nerd Fonts) icons for entry Jan 10, 2024
@Tobilike
Copy link
Contributor Author

@ingrinder I just pushed a small change, hope that's alright. I have no problem with something like that.

[Merge remote-tracking branch 'origin/Icons' into Icons](https://github.com/HorlogeSkynet/archey4/pull/144/commits/1700e9ec562babb24725ed783d52e162d555622b)

I must have done something wrong with git at the moment. Give me some time to understand. Everything is fine in my local copy.

… unexpected.

I have turned the icons on in my config. For testing.
@Tobilike
Copy link
Contributor Author

This behaves strangely.
Python -m unittest reads ~/.config/archey4/config.json but not [root]/config.json
Python -m archey reads [root]/config.json but not ~/.config/archey4/config.json

@HorlogeSkynet
Copy link
Owner

There are security checks done on file permissions. But unit tests must not depend on external environment.

@Tobilike
Copy link
Contributor Author

Thank you, now I understand it better.

@HorlogeSkynet HorlogeSkynet changed the title [FEATURE] Adds (Nerd Fonts) icons for entry [CORE] Adds (Nerd Fonts) icons for entries Jan 13, 2024
@HorlogeSkynet
Copy link
Owner

Hello @Tobilike, I've pushed some changes :

  • removed icons from sources
  • improved documentation in README
  • added support for custom icon selection from configuration
  • DRY-ed Configuration in Entry

Please tell me what you think about them before we merge this branch 🙂

Bye 👋

@Tobilike
Copy link
Contributor Author

I've looked at it, tested it, and I think it's great.

And thanks to HorlogeSkynet, ingrinder for the teamwork. I was able to learn a lot from it.

@HorlogeSkynet HorlogeSkynet self-requested a review January 14, 2024 17:53
@HorlogeSkynet HorlogeSkynet merged commit 121b1cc into HorlogeSkynet:master Jan 14, 2024
13 checks passed
Core automation moved this from IN PROGRESS to DONE Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Projects
Core
  
DONE
Development

Successfully merging this pull request may close these issues.

None yet

3 participants