Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINDOW_MANAGER] Adds display server protocol to entry #145

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

HorlogeSkynet
Copy link
Owner

See #142.

How has this been tested ?

Unit tests and locally (Debian 11).

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Jan 8, 2024
@HorlogeSkynet HorlogeSkynet added this to the v4.14.3.0 milestone Jan 8, 2024
@HorlogeSkynet HorlogeSkynet self-assigned this Jan 8, 2024
@HorlogeSkynet HorlogeSkynet added this to IN PROGRESS in OS, Distributions & Hardware via automation Jan 8, 2024
Copy link
Collaborator

@ingrinder ingrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 🎉! LGTM, possibly a bit more detail for the changelog if you agree?

CHANGELOG.md Outdated Show resolved Hide resolved
@HorlogeSkynet HorlogeSkynet changed the title [WINDOW_MANAGER] Adds display server protocol to entry [DESKTOP_ENVIRONMENT] Adds display server protocol to entry Jan 9, 2024
@HorlogeSkynet
Copy link
Owner Author

So I've checked how UI layering works and it appears showing DSP info in DE entry would be more consistent. Tell me what you think about it @Tobilike @ingrinder 🙏

@ingrinder
Copy link
Collaborator

Hmmm, how come? As far as I know you can run independent window managers without a "DE" as such in X and Wayland (e.g. i3, weston), so does it not make more sense there?

@Tobilike
Copy link
Contributor

Tobilike commented Jan 9, 2024

I tested it on Hyprland and xmonad. It is displayed in the correct place. As long as it is displayed in windows manager. Everything is fine.
Technically, you can run x11 without everything, but it doesn't really make sense. You can't do anything.

Very nice work by the way. It's much better integrated.

Co-Authored-By: Tobilike <80016610+Tobilike@users.noreply.github.com>
@HorlogeSkynet
Copy link
Owner Author

Thanks for your feedbacks (I am not an expert in UI environments at all). I've reverted to first proposal (including your CHANGELOG suggestion Michael).

Bye 👋

@HorlogeSkynet HorlogeSkynet changed the title [DESKTOP_ENVIRONMENT] Adds display server protocol to entry [WINDOW_MANAGER] Adds display server protocol to entry Jan 10, 2024
@HorlogeSkynet HorlogeSkynet merged commit d3a08e6 into master Jan 12, 2024
26 checks passed
OS, Distributions & Hardware automation moved this from IN PROGRESS to DONE Jan 12, 2024
@HorlogeSkynet HorlogeSkynet deleted the feature/wm_dsp branch April 6, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Development

Successfully merging this pull request may close these issues.

None yet

3 participants