Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOGOS] Adds {Free,Open}BSD + Updates Fedora, Ubuntu & Windows #78

Merged
merged 7 commits into from
Jun 26, 2020

Conversation

ingrinder
Copy link
Collaborator

@ingrinder ingrinder commented Jun 8, 2020

Description

  • Adds logos for OpenBSD, FreeBSD
  • Updates logo for Ubuntu to the new-style circle of friends inside a roundel.
  • Updates Fedora logo.
  • Makes lines in Windows logo look straighter.

Reason and / or context

We needed logos for the BSDs, and I thought the old Ubuntu logo was looking a bit tired. Additionally I thought the Windows & Fedora logos could do with tidying up.

How has this been tested ?

It doesn't crash when I run it with the new logos 馃槅

Screenshots

Fedora

I don't really know why I changed this one, we don't have to use this if you don't like it.
image

FreeBSD

This is the same as the FreeBSD boot-screen (as mentioned in #69)
image

OpenBSD

I couldn't find anything I quite liked for this... So I redrew Puffy in ASCII form. Let me know if you think it's any good 馃槅
image

Ubuntu

This is another one I redrew entirely from scratch, I didn't like the alternatives (I think the neofetch one is a bit naff)
image

Windows

This is just some tidying up of the edges of the windows in the flag.
image

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

+ New logo added for FreeBSD.
+ New logo added for OpenBSD.

* Updated logo for Ubuntu.
@ingrinder ingrinder added the enhancement 猬嗭笍 Implements a new feature, fixes or improves existing ones label Jun 8, 2020
@ingrinder ingrinder added this to the v4.8.0 milestone Jun 8, 2020
@ingrinder ingrinder mentioned this pull request Jun 8, 2020
13 tasks
Copy link
Owner

@HorlogeSkynet HorlogeSkynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of this, I took the liberty to re-add {c[0]} as logos lines' first character to keep a consistent look with "selected" text too.

For your (and maybe others) information, I'm currently discussing with @danyspin97 how its project liveunix/liveunix-data could provide a common and consistent way to re-use distributions meta-information across "fetch-like" projects.
Of course Archey should (and surely will) use them in the future, but we are looking forward to a "more-general-purposes" specification.

@HorlogeSkynet HorlogeSkynet changed the title [LOGOS] Add & update logos. [LOGOS] Adds FreeBSD & OpenBSD and updates Fedora, Ubuntu & Windows Jun 10, 2020
@HorlogeSkynet HorlogeSkynet changed the title [LOGOS] Adds FreeBSD & OpenBSD and updates Fedora, Ubuntu & Windows [LOGOS] Adds {Free,Open}BSD + Updates Fedora, Ubuntu & Windows Jun 26, 2020
@HorlogeSkynet HorlogeSkynet merged commit f2f9a9a into master Jun 26, 2020
OS, Distributions & Hardware automation moved this from IN PROGRESS to DONE Jun 26, 2020
@HorlogeSkynet HorlogeSkynet deleted the logo_changes branch June 26, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 猬嗭笍 Implements a new feature, fixes or improves existing ones
Development

Successfully merging this pull request may close these issues.

None yet

2 participants