-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU] [FEATURE/BREAKING] Multiple CPUs support #90
Conversation
Seems like detection may be broken in some cases https://gist.github.com/Nalorokk/91f4cced6f61ad72b6d37595c2662256 |
@Nalorokk Oh you actually tried this out 😅 Bye, thanks 👋 |
@HorlogeSkynet here it is https://gist.github.com/Nalorokk/5ce83329610bcc5102639230428014c6 . There is two examples from different machines |
Thank you very much for this. # For your 1st machine :
[
{'Intel(R) Xeon(R) CPU E5450 @ 3.00GHz': 4},
{'Intel(R) Xeon(R) CPU E5450 @ 3.00GHz': 4}
]
# For your second machine :
[
{'Intel(R) Xeon(R) CPU E5620 @ 2.40GHz': 8},
{'Intel(R) Xeon(R) CPU E5620 @ 2.40GHz': 8}
] If you're OK with the idea, I'll update this PR with a new proposal/implementation. |
> Now compatible against Python < 3.6 > Caution : new proposal so still API-breaking
Hey @Nalorokk, please find on this branch a more robust implementation that should support many setups. |
Hello @HorlogeSkynet . I tried new branch and got such output
It is way better than before. Maybe line is kinda too long though. But I just thought about it a little more and there is some another problems:
I don't have quad cpu setups around, but maybe will try mixing different cpus in one motherboard, it happens that i have combo that might work together |
Yes, there is a new option called
Latest implementation should correctly deal with such setups. Thank you very much again for your feedback @Nalorokk. 👋 |
@HorlogeSkynet i think it would be better with one line disabled by default. Thank you for your work on this topic 👍 |
Fair enough, I've just got it disabled by default for
Sure, thank you for your fast responses and your time @Nalorokk. |
* [API] : `CPU` will now be a `list` of `dict[str, int]`, representing CPUs model names and their respective number of cores ; * [CPU/GPU] : Entries items will now be displayed on multiple lines **by default**. > See also Neofetch's issue #1467. > Thanks to @Nalorokk for his suggestions.
Description
This is an API-breaking change.
Now multiple CPUs should be supported, and number of cores per CPU will be shown by default.
Text output change :
JSON API change :
See also new
one_line
&show_cores
options available forCPU
entry type.Reason and / or context
It appears Archey does not support multiple CPUs (only the first one would be displayed).
Additionally, adding the number of cores may be relevant.
See also dylanaraps/neofetch#1467 partially related.
(@Nalorokk's output suggestion has been kindly implemented there.)
How has this been tested ?
Locally and unit tests.
Types of changes :
Checklist :
develop
branch ;