Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing semicolons #11

Closed
ghost opened this issue Nov 4, 2020 · 2 comments
Closed

Missing semicolons #11

ghost opened this issue Nov 4, 2020 · 2 comments
Assignees
@HorlogeSkynet
Labels
bug Something isn't working
Projects
Thunderbird User.JS

Comments

@ghost
Copy link

ghost commented Nov 4, 2020

Hey,
A few lines are missing an ending semicolon. I think the produced user.js remains incomplete because of this.

At least these have this issue:

user_pref("mail.instrumentation.postUrl", "")
user_pref("mail.instrumentation.askUser", false)
user_pref("mail.instrumentation.userOptedIn", false)
@HorlogeSkynet
Copy link
Owner

Thanks for reporting this @wickedsp1d3r !
It looks like there is (at least) a limitation to Acorn usage about linting this project...

@HorlogeSkynet HorlogeSkynet self-assigned this Nov 4, 2020
@HorlogeSkynet HorlogeSkynet added the bug Something isn't working label Nov 4, 2020
HorlogeSkynet pushed a commit that referenced this issue Nov 5, 2020
Replaces Acorn over Travis CI by ESLint over (Microsoft) GitHub Actions
b36710a 
> See #11, Acorn was great but not sufficient for Mozilla's libPref syntax...
@HorlogeSkynet
Copy link
Owner

This is it @wickedsp1d3r, what happened shouldn't happen again with new linting procedure 🎉
https://github.com/HorlogeSkynet/thunderbird-user.js/actions

@HorlogeSkynet HorlogeSkynet mentioned this issue Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HorlogeSkynet HorlogeSkynet

Labels
bug Something isn't working
Projects
Thunderbird User.JS
DONE
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HorlogeSkynet