Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few questions after first use #21

Closed
ghost opened this issue Jun 10, 2022 · 6 comments
Closed

A few questions after first use #21

ghost opened this issue Jun 10, 2022 · 6 comments
Assignees
Labels
question Further information is requested

Comments

@ghost
Copy link

ghost commented Jun 10, 2022

Hi,
So I made the jump and started using the user.js with a few overrides. I still have a few settings to fix, but, even after looking around, I cannot seem to find the triggers responsible.
1/ Using the user.js has added a bar at the very top of the window ("Inbox - Unified folders), as shown in the picture below. From memory, that bar was not there before and the various tabs were right next to the traffic lights buttons, not under. Is this right? Can this be changed?
Schermata 2022-06-10 alle 13 02 22
2/ I have a picture included in the signature of my emails for some accounts. This picture is no longer loaded. In all fairness, that's not very surprising, but I would like to re-allow that. I have tried resetting the parameters 9211 through 9217 (also in an effort to move back to HTML messages, for instance when responding to an message with HTML), but to no avail. I also tried 9233, but that didn't work either. Any idea which switch is responsible for this? Also interested in the plain text/HTML one (the idea being that is I respond to an HTML message, the response should be HTML, so as not to break the layout).
Thanks in advance!
Dem

@HorlogeSkynet
Copy link
Owner

HorlogeSkynet commented Jun 11, 2022

Hey again Dem !

1/ Using the user.js has added a bar at the very top of the window ("Inbox - Unified folders), as shown in the picture below. From memory, that bar was not there before and the various tabs were right next to the traffic lights buttons, not under. Is this right? Can this be changed?

If I correctly get your point, you used to have tabs next to the traffic lights buttons (on TB v102 too ?), and now they are in a dedicated row below.
Maybe this has something to do with RFP (section 4500) as it impacts window layout... You could easily try by disabling it (privacy.resistFingerprinting), even if it is highly discouraged.

2/ I have a picture included in the signature of my emails for some accounts. This picture is no longer loaded. In all fairness, that's not very surprising, but I would like to re-allow that. I have tried resetting the parameters 9211 through 9217 (also in an effort to move back to HTML messages, for instance when responding to an message with HTML), but to no avail. I also tried 9233, but that didn't work either. Any idea which switch is responsible for this? Also interested in the plain text/HTML one (the idea being that is I respond to an HTML message, the response should be HTML, so as not to break the layout).

If you want to include HTML elements (e.g. an image) in your body, you will have to look at 9212 (especially the [NOTE] about shift-clicking on the compose button if you want to do this temporary 😉).
About answering to an HTML message, this is about the "auto-downgrade" feature (9213).


That being said, please note that "resetting" a preference in your user.js may not be sufficient if you previously set it. When TB is running, preferences are read, merged and kept in sync in prefs.js (which you shouldn't directly modify).
So, if you used user.js v91.1, then for instance "reset" 9212 and 9213, they would still be set to their previous values.

To workaround this, you could even :

  1. reset those preferences in your user.js and open about:config to switch them back to default for runtime too
  2. use a new profile and re-apply an user.js with those preferences commented out at first start

Arkenfox upstream calls that "cleaning preferences".


I hope this will help you 🙏
Bye 👋

@HorlogeSkynet HorlogeSkynet added the question Further information is requested label Jun 11, 2022
@HorlogeSkynet HorlogeSkynet added this to TO DO in Thunderbird User.JS via automation Jun 11, 2022
@HorlogeSkynet HorlogeSkynet moved this from TO DO to IN PROGRESS in Thunderbird User.JS Jun 11, 2022
@ghost
Copy link
Author

ghost commented Jun 12, 2022

If you want to include HTML elements (e.g. an image) in your body, you will have to look at 9212 (especially the [NOTE] about shift-clicking on the compose button if you want to do this temporary 😉).
About answering to an HTML message, this is about the "auto-downgrade" feature (9213).

Indeed, that worked. I hadn't applied the changes correctly.

Maybe this has something to do with RFP (section 4500) as it impacts window layout... You could easily try by disabling it (privacy.resistFingerprinting), even if it is highly discouraged.

Then I'd rather leave this be. I can bear with an extra bar.

Thanks a lot!

@ghost ghost closed this as completed Jun 12, 2022
Thunderbird User.JS automation moved this from IN PROGRESS to DONE Jun 12, 2022
@ghost
Copy link
Author

ghost commented Jun 12, 2022

Actually, was 9213 (mailnews.sendformat.auto_downgrade) deprecated? When I reset the pref in the editor, it seems to delete it.

@ghost ghost reopened this Jun 12, 2022
Thunderbird User.JS automation moved this from DONE to IN PROGRESS Jun 12, 2022
@HorlogeSkynet
Copy link
Owner

Actually, was 9213 (mailnews.sendformat.auto_downgrade) deprecated? When I reset the pref in the editor, it seems to delete it.

Yeah, this looks like deprecation/removal that will land in next ESR.
From source code, mailnews.sendformat.auto_downgrade and mail.default_html_action have been replaced (and automatically migrated) to mail.default_send_format.
I've added this to the project kanban for upcoming ESR work.

Reference : https://bugzilla.mozilla.org/show_bug.cgi?id=1727493

Thanks 🙇

@ghost
Copy link
Author

ghost commented Jun 14, 2022

Great! Thanks again for all the hard work!

@ghost ghost closed this as completed Jun 14, 2022
Thunderbird User.JS automation moved this from IN PROGRESS to DONE Jun 14, 2022
HorlogeSkynet pushed a commit that referenced this issue Jul 23, 2022
Thunderbird 101 replaced legacy `mail.default_html_action` and
`mailnews.sendformat.auto_downgrade` by `mail.default_send_format` new
preference to choose email sending format.

Whereas a proper "migration" is performed on first start, we stick to
plaintext email enforcement in this template, as done before.

See <https://bugzilla.mozilla.org/show_bug.cgi?id=1727493>.

> see #21
@jakeafoster
Copy link

jakeafoster commented Aug 6, 2022

1/ Using the user.js has added a bar at the very top of the window ("Inbox - Unified folders), as shown in the picture below. From memory, that bar was not there before and the various tabs were right next to the traffic lights buttons, not under. Is this right? Can this be changed?

Hi @demided, I know this issue has already been closed but I had the same problem and was able to fix it by changing 9110 (mail.tabs.autoHide) to false.

The reason this occurs is when 9110 is set to true, the tabs are hidden when there is only one tab but there still needs to be some sort of bar so Thunderbird adds one. If you have multiple tabs, the tabs appear but the bar is still show hence two rows, as in your picture.

HorlogeSkynet pushed a commit that referenced this issue Aug 24, 2022
This preference is strictly _personal_ and should not be enforced in the
template.

> see #21
> closes #25
HorlogeSkynet pushed a commit that referenced this issue Aug 24, 2022
Thunderbird 101 replaced legacy `mail.default_html_action` and
`mailnews.sendformat.auto_downgrade` by `mail.default_send_format` new
preference to choose email sending format.

Whereas a proper "migration" is performed on first start, we stick to
plaintext email enforcement in this template, as done before.

See <https://bugzilla.mozilla.org/show_bug.cgi?id=1727493>.

> see #21
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Development

No branches or pull requests

2 participants