Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call toString on args to match browser behavior. #4

Merged
merged 1 commit into from
Jul 25, 2013
Merged

Call toString on args to match browser behavior. #4

merged 1 commit into from
Jul 25, 2013

Conversation

zbjornson
Copy link
Contributor

Browsers appear to call .toString on btoa args. This package has unpredictable behavior if you pass it a non-string:

> $ node
> var btoa = require("btoa");
undefined
> btoa((Date.now() * Math.random()).toString())
'ODczNzg4ODA3MjY3LjYwOTE='
> btoa(Date.now() * Math.random())
FATAL ERROR: CALL_AND_RETRY_0 Allocation failed - process out of memory
> btoa(Date.now() * Math.random())
FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length exceeds max acceptable value
> btoa((Date.now() * Math.random()))
''

If the number is small(?), the output is wrong:

// browser:
> btoa(1234)
'MTIzNA=='
// current node-btoa
> btoa(1234)
'AAC4mHwCAAAAAP////8AAAAAeAR8AgAAAAABAAAAAAAAAKCHigAAAAAAANN6AgAAAABIMXwCAAAAAGiZfAIAAAAAAAAAAAAAAACQp5cAAAAAABhBfAIAAAAAuAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAgAAAAAABwmnwCAAAAAGiZfAIAAAAA/////8kAAAAAAAAAAAAAAFiafAIAAAAAAgAAAAAAAABomnwCAAAAAAIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAABAAAAsJyXAAAAAAAYQXwCAAAAALkAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAAAAAAAAADomXwCAAAAAP////8AAAAAKAR8AgAAAAAQN3wCAAAAAHCafAIAAAAAAAAAAAAAAAD///8fAAAAABhBfAIAAAAAaEZ8AgAAAABwkHwCAAAAAGiEfAIAAAAAKG58AgAAAACIenwCAAAAADBvfAIAAAAAkHt8AgAAAAAYQXwCAAAAAGhGfAIAAAAAcJB8AgAAAABohHwCAAAAAChufAIAAAAAiHp8AgAAAAAwb3wCAAAAAJB7fAIAAAAA2Fh8AgAAAACQXXwCAAAAALBnfAIAAAAA4Fl8AgAAAAC4aHwCAAAAABhBfAIAAAAAaEZ8AgAAAABwkHwCAAAAAGiEfAIAAAAAKG58AgAAAACIenwCAAAAADBvfAIAAAAAkHt8AgAAAADYWHwCAAAAAJBdfAIAAAAAsGd8AgAAAADgWXwCAAAAALhofAIAAAAA6Fp8AgAAAACYXnwCAAAAABBAfAIAAAAAYEV8AgAAAAA4OHwCAAAAAGAtfAIAAAAA+Bt8AgAAAAAYQXwCAAAAAGhGfAIAAAAAcJB8AgAAAABohHwCAAAAAChufAIAAAAAiHp8AgAAAAAwb3wCAAAAAJB7fAIAAAAA2Fh8AgAAAACQXXwCAAAAALBnfAIAAAAA4Fl8AgAAAAC4aHwCAAAAAOhafAIAAAAAmF58AgAAAAAQQHwCAAAAAGBFfAIAAAAAODh8AgAAAABgLXwCAAAAAPgbfAIAAAAAMCB8AgAAAAAAHXwCAAAAAKAhfAIAAAAA6Ap8AgAAAADIDHwCAAAAAOAJfAIAAAAA0A18AgAAAACIBXwCAAAAACgCfAIAAAAAwHF8AgAAAAB/AAAAAAABANA5fAIAAAAAcDp8AgAAAAAQO3wCAAAAALA7fAIAAAAAUDx8AgAAAAAoPXwCAAAAAMg9fAIAAAAAeJ18AgAAAAACAAAAAAAAAIidfAIAAAAAAgAAAAAAAAAYonwCAAAAAAEAAAAAAAAAAAAAAAAAAAAQZZcAAAAAAMBxfAIAAAAAfgAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAgAAAAAAAInXwCAAAAAAAAAAAAAAAA/////wAAAACQsJcAAAAAAMBxfAIAAAAAgAAAAAD/AQAAAAAAAAAAAAAAAAAAAAAAAAAgAAAAAACwO3wCAAAAAFA8fAIAAAAAKD18AgAAAAAAnHwCAAAAACCkfAIAAAAAiL9Jgv9/AACooHwCAAAAAA4AAAAJAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAABAAAABAAAAAAAAAAAAAAAAAAAAA=='

@coolaj86
Copy link
Collaborator

Good catch! I'll push that right away!

coolaj86 pushed a commit that referenced this pull request Jul 25, 2013
Call toString on args to match browser behavior.
@coolaj86 coolaj86 merged commit 0f12759 into HorseAJ86:master Jul 25, 2013
@zbjornson zbjornson deleted the zbpatch1 branch July 26, 2013 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants