This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
feat(date): adds date time picker #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jackcmeyer
suggested changes
Nov 28, 2019
| dateFormatCalendar?: string | ||
| /** Disable datepicker. */ | ||
| disabled?: boolean | ||
| dropdownMode: 'scroll' | 'select' |
There was a problem hiding this comment.
this prop is missing a description
| children?: ReactNode | ||
| /** The format for parsed and displayed dates. */ | ||
| dateFormat?: string | ||
| dateFormatCalendar?: string |
There was a problem hiding this comment.
this prop is missing a description
|
@martinrradev nice work! just a couple of missing prop descriptions to add. thanks for your contribution 😊 |
jackcmeyer
approved these changes
Nov 29, 2019
irvelervel
approved these changes
Nov 30, 2019
|
🎉 This PR is included in version 0.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
Changes proposed in this pull request:
Newly added dependencies with Bundlephobia links: