This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
feat(tab): add Tab and TabsHeader components #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Tab and TabsHeader components, move bootstrap import to index.tsx, fix test in button.test.tsx implement HospitalRun#24
jackcmeyer
reviewed
Jan 5, 2020
src/components/Tab/Tab.tsx
Outdated
|
|
||
| return ( | ||
| <li className="nav-item" role="tab"> | ||
| <button |
There was a problem hiding this comment.
Could this be replaced with our own Button implementation?
There was a problem hiding this comment.
Yeah good idea. I tried and it seems like it will work.
Use our Button component, differentiate between ColorVariant and ButtonVariant HospitalRun#24
jackcmeyer
previously approved these changes
Jan 5, 2020
matteovivona
approved these changes
Jan 10, 2020
matteovivona
suggested changes
Jan 10, 2020
jackcmeyer
previously approved these changes
Jan 10, 2020
matteovivona
requested review from
matteovivona
and removed request for
fox1t
matteovivona
previously approved these changes
Jan 11, 2020
matteovivona
dismissed stale reviews from jackcmeyer and themself
via
3b9cc72
matteovivona
approved these changes
Jan 11, 2020
|
🎉 This PR is included in version 0.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Changes proposed in this pull request: