This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
feat(css): create a Theme to override Bootstrap colors #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add scss to overwrite default Bootstrap colors. Add scss to toast component to demonstrate how theme can be used. HospitalRun#35
|
those tests are failing when webpack tries to load the sass files. I'll look into that |
|
Once the failing builds get fixed, I think that this looks good. I think the approach will work and it will also take care of this PR: #195 |
matteovivona
requested review from
matteovivona
and removed request for
fox1t and
irvelervel
matteovivona
approved these changes
Jan 10, 2020
|
🎉 This PR is included in version 0.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35. The colors will probably change, but the idea is to get the system in place and show how the SASS variables can also be used to theme custom and non
react-bootstrapcomponents, as I do with thereact-toastifycomponent in this PR.Changes proposed in this pull request:
Newly added dependencies with Bundlephobia links: