fix(translations): missing translations values (#1939)

* fix(translations): missing translations values * fix(tests): new translation tests
HospitalRun · Mar 23, 2020 · 79433a4 · 79433a4 · vercel · Mar 23, 2020
1 parent 5c67b72
commit 79433a4
Show file tree

Hide file tree

Showing 18 changed files with 34 additions and 18 deletions.
diff --git a/src/__tests__/patients/allergies/Allergies.test.tsx b/src/__tests__/patients/allergies/Allergies.test.tsx
@@ -127,7 +127,7 @@ describe('Allergies', () => {
 
       expect(mockedComponents.Toast).toHaveBeenCalledWith(
         'success',
-        'Success!',
+        'states.success',
         'patient.allergies.successfullyAdded',
       )
     })

diff --git a/src/__tests__/patients/diagnoses/Diagnoses.test.tsx b/src/__tests__/patients/diagnoses/Diagnoses.test.tsx
@@ -128,7 +128,7 @@ describe('Diagnoses', () => {
 
       expect(mockedComponents.Toast).toHaveBeenCalledWith(
         'success',
-        'Success!',
+        'states.success',
         'patient.diagnoses.successfullyAdded',
       )
     })

diff --git a/src/__tests__/patients/new/NewPatient.test.tsx b/src/__tests__/patients/new/NewPatient.test.tsx
@@ -153,7 +153,7 @@ describe('New Patient', () => {
     expect(history.location.pathname).toEqual(`/patients/${patient.id}`)
     expect(mockedComponents.Toast).toHaveBeenCalledWith(
       'success',
-      'Success!',
+      'states.success',
       `patients.successfullyCreated ${patient.fullName}`,
     )
   })

diff --git a/src/__tests__/patients/related-persons/RelatedPersons.test.tsx b/src/__tests__/patients/related-persons/RelatedPersons.test.tsx
@@ -166,8 +166,9 @@ describe('Related Persons Tab', () => {
 
       expect(mockedComponents.Toast).toHaveBeenCalledWith(
         'success',
-        'Success!',
-        'patient.relatedPersons.successfullyAdded',
+        'states.success',
+        'patients.successfullyAddedRelatedPerson',
+        'top-left',
       )
     })
   })

diff --git a/src/__tests__/scheduling/appointments/new/NewAppointment.test.tsx b/src/__tests__/scheduling/appointments/new/NewAppointment.test.tsx
@@ -194,7 +194,7 @@ describe('New Appointment', () => {
       expect(history.location.pathname).toEqual(`/appointments/${expectedNewAppointment.id}`)
       expect(mockedComponents.Toast).toHaveBeenCalledWith(
         'success',
-        'Success!',
+        'states.success',
         `scheduling.appointment.successfullyCreated ${expectedNewAppointment.id}`,
       )
     })

diff --git a/src/__tests__/scheduling/appointments/view/ViewAppointment.test.tsx b/src/__tests__/scheduling/appointments/view/ViewAppointment.test.tsx
@@ -282,7 +282,7 @@ describe('View Appointment', () => {
       expect(mockedComponents.Toast).toHaveBeenCalledWith(
         'success',
         'states.success',
-        'scheduling.appointments.successfullyDeleted',
+        'scheduling.appointment.successfullyDeleted',
       )
     })
   })

diff --git a/src/locales/enUs/translations/actions/index.ts b/src/locales/enUs/translations/actions/index.ts
@@ -6,5 +6,7 @@ export default {
     new: 'New',
     list: 'List',
     search: 'Search',
+    delete: 'Delete',
+    confirmDelete: 'Delete Confirmation',
   },
 }
diff --git a/src/locales/enUs/translations/patient/index.ts b/src/locales/enUs/translations/patient/index.ts
@@ -38,6 +38,7 @@ export default {
     },
     allergies: {
       label: 'Allergies',
+      allergyName: 'Allergy Name',
       new: 'Add Allergy',
       error: {
         nameRequired: 'Name is required.',

diff --git a/src/locales/enUs/translations/patients/index.ts b/src/locales/enUs/translations/patients/index.ts
@@ -2,9 +2,10 @@ export default {
   patients: {
     label: 'Patients',
     viewPatients: 'View Patients',
+    editPatient: 'Edit Patient',
     viewPatient: 'View Patient',
     newPatient: 'New Patient',
     successfullyCreated: 'Successfully created patient',
-    successfullyAddedRelatedPerson: 'Successfully added the new related person',
+    successfullyAddedRelatedPerson: 'Successfully added a new related person',
   },
 }
diff --git a/src/locales/enUs/translations/scheduling/index.ts b/src/locales/enUs/translations/scheduling/index.ts
@@ -5,6 +5,8 @@ export default {
       label: 'Appointments',
       new: 'New Appointment',
       deleteAppointment: 'Delete Appointment',
+      viewAppointment: 'Appointment',
+      editAppointment: 'Edit Appointment',
     },
     appointment: {
       startDate: 'Start Date',
@@ -26,6 +28,8 @@ export default {
       },
       reason: 'Reason',
       patient: 'Patient',
+      successfullyDeleted: 'Appointment successfully deleted.',
+      deleteConfirmationMessage: 'Are you sure you want to delete this appointment?',
     },
   },
 }
diff --git a/src/patients/allergies/Allergies.tsx b/src/patients/allergies/Allergies.tsx
@@ -31,7 +31,7 @@ const Allergies = (props: AllergiesProps) => {
   useAddBreadcrumbs(breadcrumbs)
 
   const onAddAllergySuccess = () => {
-    Toast('success', t('Success!'), `${t('patient.allergies.successfullyAdded')}`)
+    Toast('success', t('states.success'), `${t('patient.allergies.successfullyAdded')}`)
   }
 
   const onAddAllergy = (allergy: Allergy) => {

diff --git a/src/patients/allergies/NewAllergyModal.tsx b/src/patients/allergies/NewAllergyModal.tsx
@@ -50,9 +50,9 @@ const NewAllergyModal = (props: NewAllergyModalProps) => {
       <form>
         <TextInputWithLabelFormGroup
           name="name"
-          label="Name"
+          label={t('patient.allergies.allergyName')}
           isEditable
-          placeholder="Allergy"
+          placeholder={t('patient.allergies.allergyName')}
           value={allergy.name}
           onChange={onNameChange}
         />

diff --git a/src/patients/diagnoses/Diagnoses.tsx b/src/patients/diagnoses/Diagnoses.tsx
@@ -36,7 +36,7 @@ const Diagnoses = (props: Props) => {
   }
 
   const onAddDiagnosisSuccess = () => {
-    Toast('success', t('Success!'), t('patient.diagnoses.successfullyAdded'))
+    Toast('success', t('states.success'), t('patient.diagnoses.successfullyAdded'))
   }
 
   const onDiagnosisSave = (diagnosis: Diagnosis) => {

diff --git a/src/patients/edit/EditPatient.tsx b/src/patients/edit/EditPatient.tsx
@@ -59,7 +59,11 @@ const EditPatient = () => {
 
   const onSuccessfulSave = (updatedPatient: Patient) => {
     history.push(`/patients/${updatedPatient.id}`)
-    Toast('success', t('Success!'), `${t('patients.successfullyUpdated')} ${patient.fullName}`)
+    Toast(
+      'success',
+      t('states.success'),
+      `${t('patients.successfullyUpdated')} ${patient.fullName}`,
+    )
   }
 
   const onSave = () => {

diff --git a/src/patients/new/NewPatient.tsx b/src/patients/new/NewPatient.tsx
@@ -33,7 +33,11 @@ const NewPatient = () => {
 
   const onSuccessfulSave = (newPatient: Patient) => {
     history.push(`/patients/${newPatient.id}`)
-    Toast('success', t('Success!'), `${t('patients.successfullyCreated')} ${newPatient.fullName}`)
+    Toast(
+      'success',
+      t('states.success'),
+      `${t('patients.successfullyCreated')} ${newPatient.fullName}`,
+    )
   }
 
   const onSave = () => {

diff --git a/src/patients/related-persons/RelatedPersonTab.tsx b/src/patients/related-persons/RelatedPersonTab.tsx
@@ -67,8 +67,7 @@ const RelatedPersonTab = (props: Props) => {
   }
 
   const onAddRelatedPersonSuccess = () => {
-    Toast('success', t('Success!'), t('patient.relatedPersons.successfullyAdded'))
-    Toast('success', t('Success!'), t('patients.successfullyAddedRelatedPerson'), 'top-left')
+    Toast('success', t('states.success'), t('patients.successfullyAddedRelatedPerson'), 'top-left')
   }
 
   const onRelatedPersonSave = (relatedPerson: RelatedPerson) => {

diff --git a/src/scheduling/appointments/new/NewAppointment.tsx b/src/scheduling/appointments/new/NewAppointment.tsx
@@ -44,7 +44,7 @@ const NewAppointment = () => {
     history.push(`/appointments/${newAppointment.id}`)
     Toast(
       'success',
-      t('Success!'),
+      t('states.success'),
       `${t('scheduling.appointment.successfullyCreated')} ${newAppointment.id}`,
     )
   }

diff --git a/src/scheduling/appointments/view/ViewAppointment.tsx b/src/scheduling/appointments/view/ViewAppointment.tsx
@@ -31,7 +31,7 @@ const ViewAppointment = () => {
 
   const onDeleteSuccess = () => {
     history.push('/appointments')
-    Toast('success', t('states.success'), t('scheduling.appointments.successfullyDeleted'))
+    Toast('success', t('states.success'), t('scheduling.appointment.successfullyDeleted'))
   }
 
   const onDeleteConfirmationButtonClick = () => {