Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Create New Date/Timepicker Solution #1501

Closed
donaldwasserman opened this issue Sep 1, 2018 · 7 comments
Closed

Create New Date/Timepicker Solution #1501

donaldwasserman opened this issue Sep 1, 2018 · 7 comments
Labels
deprecation duplicate indicates that an issue/pull request is a duplicate of another issue/pull request

Comments

@donaldwasserman
Copy link
Contributor

donaldwasserman commented Sep 1, 2018

Currently, HR frontend is using a datepicker solution that relies on an outdated and unmaintained date/time picker library: https://github.com/owenmead/Pikaday

See:
https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/components/date-picker-wrapper.js
https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/components/date-picker.js

Developing a better solution that relies on ember-power-calendar or a different better date picking library would be ideal.

Requirements

  • A user must be able to type, select, edit dates with a keyboard or mouse
  • No jQuery dependency
  • All existing acceptance tests must pass
  • Use Ember best practices (like contextual components)
  • Must integrate with existing validations library
  • Prefer an existing, maintained, ember addon
@donaldwasserman donaldwasserman added help wanted indicates that an issue is open for contributions Ember Expert good first issue indicates an issue is good for a first time contributor labels Sep 1, 2018
@surajdubey
Copy link

@donaldwasserman I’d love to work on it

@donaldwasserman
Copy link
Contributor Author

@surajdubey That would be great - I added some requirements above. If you're taking a stab at it, i'll mark this issue as in progress!

Thanks for the help!

@donaldwasserman donaldwasserman added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Sep 18, 2018
@surajdubey
Copy link

Sure @donaldwasserman
Thanks for modifying the tags.

@stale
Copy link

stale bot commented Aug 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix indicates an issue/pull request will not be worked on label Aug 7, 2019
@fox1t fox1t removed the Ember Expert label Aug 7, 2019
@stale stale bot removed the wontfix indicates an issue/pull request will not be worked on label Aug 7, 2019
@stale
Copy link

stale bot commented Oct 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix indicates an issue/pull request will not be worked on label Oct 6, 2019
@pat154
Copy link

pat154 commented Nov 10, 2019

@surajdubey Hey mate, are you still looking at this issue? If not I'd be happy to take over or help out. Cheers!

@stale stale bot removed the wontfix indicates an issue/pull request will not be worked on label Nov 10, 2019
@matteovivona matteovivona added deprecation and removed in progress indicates that issue/pull request is currently being worked on good first issue indicates an issue is good for a first time contributor labels Nov 11, 2019
@jackcmeyer
Copy link
Member

Closing issue in favor of HospitalRun/components#34

@jackcmeyer jackcmeyer added the duplicate indicates that an issue/pull request is a duplicate of another issue/pull request label Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
deprecation duplicate indicates that an issue/pull request is a duplicate of another issue/pull request
Projects
None yet
Development

No branches or pull requests

6 participants