Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add Allergy should provide better error feedback #1924

Closed
jackcmeyer opened this issue Mar 19, 2020 · 7 comments · Fixed by #1945
Closed

Add Allergy should provide better error feedback #1924

jackcmeyer opened this issue Mar 19, 2020 · 7 comments · Fixed by #1945
Assignees
@cfiorini74
Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

🚀 Feature Proposal

I would like the add allergy modal to provide better feedback for error messages.

Currently, the only error message is a banner error message.

After the completion of this issue, I would like it to provide feedback at the field level when possible.

The following should happen:

  • When a name is not filled in, the name field should highlight in red, and provide feedback saying Name is required.
  • The banner message should read Unable to add allergy..

Motivation

Better user experience.
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Mar 19, 2020
@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions patients issue/pull request that interacts with patients module labels Mar 19, 2020
@jackcmeyer jackcmeyer added this to To do in Version 2.0 via automation Mar 19, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 19, 2020
@cfiorini74
Copy link
Contributor

Hi Jack,
I'd like to work on this issue.

@jackcmeyer
Copy link
Member Author

Sounds good, I've assigned this to you, @cfiorini74.

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 21, 2020
cfiorini74 added a commit to cfiorini74/hospitalrun-frontend that referenced this issue Mar 26, 2020
@cfiorini74
feat(newallergymodel.tsx and english index.ts): fix for issue Hospita…
57541a8 
…lRun#1924

Changes made in NewAllergyModel.tsx for two new hooks to store isInvalid boolean and textInput
feedback. Additional error added to allergies in English index.ts

fix HospitalRun#1924
cfiorini74 added a commit to cfiorini74/hospitalrun-frontend that referenced this issue Mar 26, 2020
@cfiorini74
style(newallergymodal.tsx): change variable names in NewAllergyModal.tsx
b0d61d1 
Change names of boolean which stores if input is invalid in NewAllergyModal.tsx for clarity

fix HospitalRun#1924
cfiorini74 added a commit to cfiorini74/hospitalrun-frontend that referenced this issue Mar 29, 2020
@cfiorini74
fix(newallergymodel.test.tsx): change variable in newallergymodel test
d06b9df 
Changes variable in test for newallergymodel as String for the alert in actual newallergymodel.tsx
has been changed.

fix HospitalRun#1924
@hemantpandey17
Copy link
Contributor

Is it still on ?

@jackcmeyer
Copy link
Member Author

@hemantpandey17 looks like this still available. Would you like to complete it still? Sorry I missed this message.

@hemantpandey17
Copy link
Contributor

I can take that.

@cfiorini74
Copy link
Contributor

I think I might have done this feature already in this pull request. Wasn't sure how to directly link it with this issue, sorry.

@jackcmeyer
Copy link
Member Author

Confirmed that the PR @cfiorini74 linked closes this issue.

Version 2.0 automation moved this from To do to Done Apr 21, 2020
@jackcmeyer jackcmeyer linked a pull request Apr 21, 2020 that will close this issue
feat(patients): better form feedback for add allergy #1945
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cfiorini74 cfiorini74

Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat(patients): better form feedback for add allergy cfiorini74/hospitalrun-frontend
3 participants
@hemantpandey17 @jackcmeyer @cfiorini74