Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix: standardize mock store setup in tests #2075

Merged
merged 5 commits into from May 17, 2020
Merged

fix: standardize mock store setup in tests #2075

merged 5 commits into from May 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 14, 2020

Fixes #2062.

  • Replaced configureMocks with createMockStore in tests.
  • Added as any to the input of createMockStore where absent.

@jsf-clabot
Copy link

jsf-clabot commented May 14, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented May 14, 2020 •
edited

@vercel
Copy link

vercel bot commented May 14, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/bsge8v1h7
✅ Preview: https://hospitalrun-fr-git-fork-kumikokashii-standardize-mock-st-4b966e.hospitalrun.now.sh

@ghost ghost mentioned this pull request May 14, 2020
Closed
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label May 14, 2020
@matteovivona matteovivona added this to In progress in Version 2.0 via automation May 14, 2020
@matteovivona matteovivona added this to the v2.0 milestone May 14, 2020
matteovivona
matteovivona previously approved these changes May 14, 2020
View reviewed changes
jackcmeyer
jackcmeyer previously approved these changes May 16, 2020
View reviewed changes
@jackcmeyer jackcmeyer added the 🚀enhancement an issue/pull request that adds a feature to the application label May 16, 2020
@matteovivona
Copy link
Contributor

@kumikokashii there are a lot of conflicts. Could you fix them? thanks

@jackcmeyer
Copy link
Member

hi @kumikokashii. There are some merge conflicts to be fixed.

@ghost ghost dismissed stale reviews from jackcmeyer and matteovivona via 220b2fa May 17, 2020 21:11
@jackcmeyer jackcmeyer merged commit 50f9e49 into HospitalRun:master May 17, 2020
Version 2.0 automation moved this from In progress to Done May 17, 2020
@ghost ghost deleted the standardize-mock-store-setup-in-tests branch June 17, 2020 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fox1t fox1t Awaiting requested review from fox1t

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Standardize mock store setup in tests
3 participants
@jsf-clabot @matteovivona @jackcmeyer