Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Focus of menu item "Visits" disappears when I view the details #2563

Closed
matteovivona opened this issue Feb 9, 2021 · 2 comments · Fixed by #2565
Closed

Focus of menu item "Visits" disappears when I view the details #2563

matteovivona opened this issue Feb 9, 2021 · 2 comments · Fixed by #2565
Assignees
@agusbrand
Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Projects
Version 2.0
Milestone
v2.0

Comments

@matteovivona
Copy link
Contributor

🐛 Bug Report

A clear and concise description of what the bug is.

To Reproduce

When I view a visit detail tab, the focus of the "Visits" menu item disappears preventing me from understanding in which section I'm in.

Right behavior

Screenshot 2021-02-09 at 12 38 19

Wrong behavior

Screenshot 2021-02-09 at 12 38 25
@matteovivona matteovivona added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions good first issue indicates an issue is good for a first time contributor LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) labels Feb 9, 2021
@matteovivona matteovivona added this to the v2.0 milestone Feb 9, 2021
@matteovivona matteovivona added this to To do in Version 2.0 via automation Feb 9, 2021
@agusbrand
Copy link
Contributor

I would like to take this as my first contribution

@matteovivona matteovivona added in progress indicates that issue/pull request is currently being worked on and removed good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions labels Feb 9, 2021
@matteovivona
Copy link
Contributor Author

Ok @agusbrand

agusbrand added a commit to agusbrand/hospitalrun-frontend that referenced this issue Feb 10, 2021
@agusbrand
refactor: return empty patient visits array instead of undefined
6bcfab9 
HospitalRun#2563
agusbrand added a commit to agusbrand/hospitalrun-frontend that referenced this issue Feb 10, 2021
@agusbrand
feat(visittable): add missing warning alert when if there are no visits
31e3f45 
HospitalRun#2563
agusbrand added a commit to agusbrand/hospitalrun-frontend that referenced this issue Feb 10, 2021
@agusbrand
test(visittable): add warning alert test
d67db62 
HospitalRun#2563
agusbrand added a commit to agusbrand/hospitalrun-frontend that referenced this issue Feb 10, 2021
@agusbrand
test(viewpatient): add missing visits tab test
2795f44 
HospitalRun#2563
agusbrand added a commit to agusbrand/hospitalrun-frontend that referenced this issue Feb 10, 2021
@agusbrand
fix(viewpatient): keep corresponding tabs as active for nested routes
9334401 
HospitalRun#2563
@agusbrand agusbrand mentioned this issue Feb 10, 2021
Merged
Version 2.0 automation moved this from To do to Done Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@agusbrand agusbrand

Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix(viewpatient): keep tabs active for nested routes agusbrand/hospitalrun-frontend
2 participants
@matteovivona @agusbrand