This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Changed amountOwedChanged back to observer. #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add some test cases as well.. |
|
Let me know if you don't like the "Calculate totals" test, it is my attempt to test the calculated fields logic on the edit invoice page, but not sure it's in line with the style of other tests in the project. Also takes like 10 seconds to run. |
tangollama
approved these changes
May 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1440.
Changes proposed in this pull request:
This PR reverts the change to amountOwedChanged from 4b313ef. It had been changed from an observer to a computed property, but the property is never accessed anywhere so it doesn't get updated correctly.
cc @HospitalRun/core-maintainers