Remove Bower #1466
Remove Bower #1466
Conversation
|
|
| "timekeeper": "^1.0.0", | ||
| "webrtc-adapter": "^3.1.3" | ||
| } | ||
| "name": "hospitalrun" |
There was a problem hiding this comment.
Why do we still need this file? Kill it?
package.json
Outdated
| "worker-pouch": "2.1.0" | ||
| }, | ||
| "dependencies": { | ||
| "broccoli-funnel": "^2.0.1", |
There was a problem hiding this comment.
Why were so many packages moved to dependencies and not in the devDeps? I'd say we deliver our assets which already contain everything bundled; probably it's not worth to explicitly require some packages to be installed afterwards. Correct me if I'm wrong.
There was a problem hiding this comment.
TBH, it's because I can never remember the difference in commands between yarn add and the npm i --save-dev.
I assume the electron stuff is a requirement there for how the electron builds happen. I moved everything up to dependencies minus the electron stuff.
|
@MatthewDorner probably the same error we had with our |
|
@stukalin All the tests are covered (with the exception of the barcode one, which requires a configuration setting to be toggled to connect to a printer, which if you have an idea of how to handle that, let me know). Just updated master, hopefully things are still green 🤞 |
|
Still getting this one when I try to npm install, but if I use yarn it will work. |
|
@MatthewDorner What version of NPM are you using? Mine seems to be downloading fine, but I'm on 5.3 Also, I'm running that locally on my mac, rather than on a VM |
|
I'm on node 6.14.4 and npm 3.10.10. Let me try with node 8.11.4 and npm v5.6.0. Result: same problem. But doesn't list pikaday and typeahead at all in the npm output. Now node 10.10.0 and npm 6.4.1: it crashes when building leveldown. This may be related to something else, I'm on Ubuntu 18.04 now and I needed to install python, make and g++ due to the leveldown dependency (edit: I never had to do that on Ubuntu 16.04), maybe I did something wrong, although it was building fine for the other npm versions. |
|
So crashing building leveldown is related to that python issue. You need to
have `python2` available in your path. I'm sure you installed python3.
Not sure what's going on here with npm.
…On Sat, Sep 8, 2018 at 10:19 PM Matthew Dorner ***@***.***> wrote:
I'm on node 6.14.4 and npm 3.10.10.
Let me try with node 8.11.4 and npm v5.6.0. Result: same problem. But
doesn't list pikaday and typeahead at all in the npm output.
Now node 10.10.0 and npm 6.4.1: it crashes when building leveldown. This
may be related to something else, I'm on Ubuntu 18.04 now and I needed to
install python, make and g++ due to the leveldown dependency, maybe I did
something wrong, although it was building fine for the other npm versions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1466 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE9j6twQ8TiOnXhWOta8-aBuXoN2FKRMks5uZHq8gaJpZM4VjsaF>
.
|
|
I think it's this, https://stackoverflow.com/questions/43081427/private-github-repo-as-dependency-is-extraneous-on-npm-install, I'm testing to see if I can fix it. |
|
I changed the names in package.json and ember-cli-build to what they are in the package.json of those actual repos (to pikaday-time instead of pikaday and typeahead.js instead of typeahead). I get farther but still get this error unless I use yarn. Could just tell people to use yarn? |
|
@MatthewDorner That's the issue. The barcode.js issue you're running into is a problem with an upstream package. I fixed the issue and just pointed to my branch. |
|
@MatthewDorner @stukalin You guys see any other issues? |
|
nope |
|
If you commit the last changes you referred to I'll test it again, but I think it'll be fine. |
|
Alright, I think it's all good. Just updated, npm installed, yarn installed, tests passed locally, hopefully they'll pass in travis... Moving forward here, I think. |
Fixes #1465.
See issue for detailed package breakdown.
Notes:
cc @HospitalRun/core-maintainers