-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
ember-intl implementation fixes #1562
ember-intl implementation fixes #1562
Conversation
61a64b5
to
30e9f59
Compare
30e9f59
to
7ccc9f4
Compare
- Change the css implmentation to use the root body direction attribute. - Use rtl-detect instead of managing rtl configuration
aa8cae7
to
fa16f3a
Compare
Took a look at the RTL with Urdu language, looks good except I noticed something else: the font changes. It even sometimes changes in the middle of a translation item, and there's no HTML or anything in the translation string, I wonder what it is. And I don't see this in any other locale even other RTL ones. Also noticed some additional issues that were also present before the switch to intl so I can make a new issue for those later. |
And, checked and that font thing happened before the RTL changes, but it is somehow related to switching to ember-intl. We can just put it with the other things to check out later. Everything else looks good, are you still working on anything? |
That's really interesting actually. I can't explain the font change for urdu. The characters look like they could be the same, I'm not sure if the change is acceptable or not either. I agree, let's do this as a separate issue and I'm happy to also investigate. Nothing else for this PR from my end, thanks! 👍 |
The characters look to be identical, just different font so I doubt it's a big deal. Thanks for the quick fixes. |
Actually one more thing occurs to me, in #1458 we set all those translation keys to undefined instead of removing them so people could more easily see in the file what keys need to be translated. Would it be better to comment them out instead of removing them entirely? |
Maybe that's not a good idea either since if people add keys, they'll just forget to add commented out keys in the other languages so they still won't stay synced up. |
Partially fixes #1561.
cc @HospitalRun/core-maintainers